Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deposit: add anchor IDs to sections #2976

Closed

Conversation

carlinmack
Copy link
Contributor

@carlinmack carlinmack commented Feb 12, 2025

❤️ Thank you for your contribution!

Close #2977

Description

Please describe briefly your pull request.

image

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@carlinmack carlinmack requested review from slint and kpsherva February 12, 2025 14:21
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming-wise looks good, I like -section suffix convention.

We also need to do something for the more "dynamic" sections, i.e.:

  • the "Software", "Conference", "Publishing information" sections that originate from custom fields
  • the "Domain specific fields" section, which are also custom fields, but configured/displayed differently

@carlinmack
Copy link
Contributor Author

yep on it :)

@0einstein0
Copy link
Member

Closing in favour of #2983

@0einstein0 0einstein0 closed this Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add anchor IDs to sections of deposit form
3 participants