fix: reuse request template rather than duplicating #3189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzacharo
approved these changes
Oct 15, 2025
Member
zzacharo
left a comment
zzacharo
left a comment
There was a problem hiding this comment.
@carlinmack this looks good to me, do you still work on it?
Contributor
Author
|
nope this is ready :) |
Open
10 tasks
kpsherva
reviewed
Oct 27, 2025
| {% from "invenio_requests/macros/request_header.html" import inclusion_request_header %} | ||
|
|
||
| {% set title = invenio_request.title %} | ||
| {% set base_template = admin_base_template %} |
Contributor
There was a problem hiding this comment.
nice thought for reusing templates - just a little warning, you might be in trouble though to provide all the context needed for the parent template to work, especially when making changes
Contributor
There was a problem hiding this comment.
suggestion, to be tested if it wasn't done yet: all the request views
Contributor
|
This PR was automatically marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: