Skip to content

Conversation

@mkloeppe
Copy link
Contributor

@mkloeppe mkloeppe commented Nov 19, 2025

❤️ Thank you for your contribution!

Description

In accordance with the already existing Overridable

<Overridable
  id="InvenioAppRdm.Deposit.BasicInformation.after.container"
/>

We added an <Overridable/>

  • directly before the files accordion and
  • directly after the files accordion.

in order to have additional entry points for React components.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@mkloeppe mkloeppe force-pushed the implement-overridable-after-files-accordion branch from 5244287 to e2d1df2 Compare December 10, 2025 13:08
@mkloeppe mkloeppe changed the title Add an Overridable after the files accordion Add an empty Overridable container before and after the files accordion Dec 10, 2025
Copy link
Contributor

@wgresshoff wgresshoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can judge this looks ok for me, ids are following the standards. But I'm no expert here, so a second pair of eyes are needed here.

Copy link
Member

@Samk13 Samk13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, The extension points are fine. The prop list is bloated and noisy but tolerable since Overridable blocks already expect fat payloads in this codebase.
No functional risk to me.

@wgresshoff wgresshoff merged commit 0ec0c02 into inveniosoftware:master Dec 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants