Skip to content

Conversation

@0einstein0
Copy link
Member

❤️ Thank you for your contribution!

Description

Partially Closes #581

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

new CopyWebpackPlugin({
patterns: [
{
from: path.resolve(__dirname, '../node_modules/@wiris/mathtype-tinymce6/plugin.min.js'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by adding this, we populate plugins for tinymce even for instances which do not have tinymce, I am not sure if it is the best approach

@utnapischtim utnapischtim moved this to Triage in vNext Mar 12, 2025
@max-moser max-moser moved this from Triage to 📋 To discuss in vNext Mar 26, 2025
@max-moser
Copy link
Contributor

Is this still relevant?

In the meanwhile, we've introduced the copy from/to instructions in webpack configs.
One of those is actually related to TinyMCE in Invenio-App-RDM.
Perhaps it should be implemented there instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋 To discuss

Development

Successfully merging this pull request may close these issues.

3 participants