Skip to content

Conversation

@slint
Copy link
Member

@slint slint commented Sep 10, 2024

needs flask-webpackext PR
needs pywebpack PR

@utnapischtim
Copy link
Contributor

the commits d04b307, ab19770 and 6efde66 could be reverted. the main idea of those commits was to enable the possibility to give the app to the class directly to make it configurable which app is used.

since invenio-cli doesn't use that approach anymore those changes are not necessary anymore.

it could be helpful in the future to keep those changes, but for now they are not used anymore.

this would reduce the changes in this commit.

reverts with the same idea could be done in flask-webpackext too, described here: inveniosoftware/flask-webpackext#26 (comment)

"@rspack/core": ">1.0.0",
"@rspack/dev-server": ">1.0.0",
"webpack-bundle-analyzer": "^4.0.0",
"webpack-bundle-tracker": "^1.0.0",
Copy link

@mirekys mirekys Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version now raises the following error on-build:

# with Node v22
[rspack-cli] TypeError: stripAnsi is not a function
    at BundleTrackerPlugin._handleDone
...

thats because required stripAnsi function is now ESM module with default export, not direct function.
See here: django-webpack/webpack-bundle-tracker#121
@utnapischtim @slint

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our pins are a bit too aggressive in general. Have you tried bumping to the 3.x releases?

Copy link

@mirekys mirekys Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, but there are breaking changes to the plug-in config, mainly regarding path handling, we'd need to migrate accordding to README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants