-
Notifications
You must be signed in to change notification settings - Fork 49
WIP build: migrate to Rspack #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
cc4436a to
ddb7b3f
Compare
* this makes it possible to give app context to the WebpackBundleProject
* Deprecation The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.
|
the commits d04b307, ab19770 and 6efde66 could be reverted. the main idea of those commits was to enable the possibility to give the app to the class directly to make it configurable which app is used. since it could be helpful in the future to keep those changes, but for now they are not used anymore. this would reduce the changes in this commit. reverts with the same idea could be done in |
| "@rspack/core": ">1.0.0", | ||
| "@rspack/dev-server": ">1.0.0", | ||
| "webpack-bundle-analyzer": "^4.0.0", | ||
| "webpack-bundle-tracker": "^1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version now raises the following error on-build:
# with Node v22
[rspack-cli] TypeError: stripAnsi is not a function
at BundleTrackerPlugin._handleDone
...
thats because required stripAnsi function is now ESM module with default export, not direct function.
See here: django-webpack/webpack-bundle-tracker#121
@utnapischtim @slint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think our pins are a bit too aggressive in general. Have you tried bumping to the 3.x releases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried, but there are breaking changes to the plug-in config, mainly regarding path handling, we'd need to migrate accordding to README
needs flask-webpackext PR
needs pywebpack PR