Skip to content

using translated string for displaying role #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmorrell merged 1 commit into from
Jun 10, 2025
Merged

using translated string for displaying role #1291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions invenio_communities/assets/semantic-ui/js/invenio_communities/members/Filters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ export class Filters {

getVisibility() {
const values = [
{ key: "true", label: "Public" },
{ key: "false", label: "Hidden" },
{ key: "true", label: i18next.t("Public") },
{ key: "false", label: i18next.t("Hidden") },
];
return this.serializeFilter("visibility", "Visibility", values);
}
Expand Down Expand Up @@ -56,7 +56,7 @@ export class Filters {
}

getHumanReadableVisibility(value) {
return value === "true" ? "Public" : "Hidden";
return value === "true" ? i18next.t("Public") : i18next.t("Hidden");
}

getDisplayValue(filter) {
Expand Down
7 changes: 6 additions & 1 deletion ...mantic-ui/js/invenio_communities/members/members/manager_view/ManagerMembersResultItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ export class ManagerMembersResultItem extends Component {
const { api } = this.context;
const membershipRelativeTimestamp = timestampToRelativeTime(result.created);
const memberVisibility = result.visible ? i18next.t("Public") : i18next.t("Hidden");

const roleTitle =
config?.allRoles?.find((role) => role.name === result.role)?.title ||
_upperFirst(result.role);

return (
<Table.Row>
<Table.Cell>
Expand Down Expand Up @@ -148,7 +153,7 @@ export class ManagerMembersResultItem extends Component {
label={i18next.t("Role") + " " + result.role}
/>
) : (
_upperFirst(result.role)
roleTitle
)}
</Table.Cell>

Expand Down
1 change: 1 addition & 0 deletions ...mmunities/assets/semantic-ui/js/invenio_communities/members/members/manager_view/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ const ManagerMembersResultItemWithConfig = parametrize(ManagerMembersResultItem,
rolesCanUpdate: communitiesRolesCanUpdate,
visibility: memberVisibilityTypes,
permissions: permissions,
allRoles: communitiesAllRoles,
},
});

Expand Down
1 change: 1 addition & 0 deletions ...ommunities/assets/semantic-ui/js/invenio_communities/members/members/member_view/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const ManagerMembersResultItemWithConfig = parametrize(ManagerMembersResultItem,
rolesCanUpdate: communitiesRolesCanUpdate,
visibility: memberVisibilityTypes,
permissions: permissions,
allRoles: communitiesAllRoles,
},
});

Expand Down
Loading