email: use name as email for groups #45
Conversation
jrcastro2
commented
Dec 8, 2025
jrcastro2
commented
- closes 1 - Enhance e-mail notifications CERNDocumentServer/cds-rdm#628
jrcastro2
force-pushed
the
add-group-email
branch
from
baab603 to
313912b
Compare
| email = ( | ||
| recipient.data.get("email") | ||
| or recipient.data.get("email_hidden") | ||
| or recipient.data.get("name") |
There was a problem hiding this comment.
this part will be only true for CERN, no? we can't always assume group name == email can we? also where do we get the email domain from?
There was a problem hiding this comment.
This would be true to anyone using groups with emails. That's right we cannot assume that the group name will always be the email. I guess it makes sense that we do add the email field to the group but be aware that we will need to also update the the group sync in CDS. Please confirm that we want to update the data model for the groups and I will do it.
There was a problem hiding this comment.
I am wondering, how did you test that email is sent for CDS? sorry I am a bit lost on this assumption that e-group name == e-group email address
There was a problem hiding this comment.
Looks like that in both Google Workspace and MS the name and the e-mail are the same.
For simplicity, we could start with that assumption.
There was a problem hiding this comment.
if we start with this assumption, we are still missing the part which makes it work for CERN use case (adding @ is not present to properly send the email)
| content = self.render_template(notification, recipient) | ||
|
|
||
| # Groups use the name as email if no email is set | ||
| email = ( |
There was a problem hiding this comment.
Could it be None in any possible way? Should it be handled?
3 participants
