Add internationalisation support #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slint
approved these changes
Feb 13, 2025
invenio_pages/records/models.py
Outdated
| @@ -36,6 +37,9 @@ class PageModel(db.Model, Timestamp): | |||
| title = db.Column(db.String(200), nullable=False, default="") | |||
| """Page title.""" | |||
|
|
|||
| lang = db.Column(db.String(2), nullable=False, default="en") | |||
There was a problem hiding this comment.
minor/question: (probably I18N/L10N experts can jump in) is this the best format to store the language? E.g. could en-US or similar be better and map to the overall translations process? This would affect the string size, i.e. 2 vs. 5 (or even higher?)
There was a problem hiding this comment.
I'm not an expert but this is the information the UI provides?! This follows the settings in I18N_LANGUAGES.
Co-authored-by: Alex Ioannidis <[email protected]>
Co-authored-by: Alex Ioannidis <[email protected]>
Open
10 tasks
…hanges. This makes the alembic tests run, too!
|
Merged with using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Add internationalisation support. By adding a lang column and extendig the unique constraint the goal is achieved. This feature is available in the Administration interface as well.
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: