Skip to content

(fix)lift embargo: removing pid reserving #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kpsherva wants to merge 1 commit into
base: master
Choose a base branch
from
Open

(fix)lift embargo: removing pid reserving #2137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion invenio_rdm_records/services/services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ def lift_embargo(self, identity, _id, uow=None):
"lift_embargo", identity, draft=draft, record=record, uow=uow
)

self._pids.pid_manager.create_and_reserve(record)
Copy link
Member

@ptamarit ptamarit Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking one unit test.

uow.register(RecordCommitOp(record, indexer=self.indexer))
uow.register(TaskOp(register_or_update_pid, record["id"], "doi", parent=False))
# If the record was previously public it will still keep the parent PID
Copy link
Member

@ptamarit ptamarit Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the parent PID logic also be removed?

Expand Down
Loading