Mark translatable strings#2293
Merged
tmorrell merged 1 commit intoinveniosoftware:masterfrom Mar 31, 2026
Merged
Conversation
Samk13
requested changes
Mar 31, 2026
Member
Samk13
left a comment
There was a problem hiding this comment.
Thanks for this @SarahW91!
You can omit the second commit, as it’s not needed. This step will happen automatically upon publish, see: https://github.com/inveniosoftware/workflows/blob/master/.github/workflows/pypi-publish.yml#L73
Once that's done its good to go!
31f61cf to
53dbcd8
Compare
Contributor
Author
|
Thanks for that hint, I removed the commit! |
Samk13
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Marked two strings as translatable via i18next.t that were previously not
Checklist