Skip to content

Mark translatable strings#2293

Merged
tmorrell merged 1 commit intoinveniosoftware:masterfrom
ulbmuenster:mark_translatable_strings
Mar 31, 2026
Merged

Mark translatable strings#2293
tmorrell merged 1 commit intoinveniosoftware:masterfrom
ulbmuenster:mark_translatable_strings

Conversation

@SarahW91
Copy link
Copy Markdown
Contributor

Description

Marked two strings as translatable via i18next.t that were previously not

Checklist

@SarahW91 SarahW91 requested a review from Samk13 March 31, 2026 07:50
Copy link
Copy Markdown
Member

@Samk13 Samk13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @SarahW91!
You can omit the second commit, as it’s not needed. This step will happen automatically upon publish, see: https://github.com/inveniosoftware/workflows/blob/master/.github/workflows/pypi-publish.yml#L73
Once that's done its good to go!

@SarahW91 SarahW91 force-pushed the mark_translatable_strings branch from 31f61cf to 53dbcd8 Compare March 31, 2026 08:03
@SarahW91
Copy link
Copy Markdown
Contributor Author

Thanks for that hint, I removed the commit!

@SarahW91 SarahW91 requested a review from Samk13 March 31, 2026 08:26
@tmorrell tmorrell merged commit 65315be into inveniosoftware:master Mar 31, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants