feat(reviews): add config for record version review policy#2324
Open
palkerecsenyi wants to merge 1 commit intoinveniosoftware:masterfrom
Open
feat(reviews): add config for record version review policy#2324palkerecsenyi wants to merge 1 commit intoinveniosoftware:masterfrom
palkerecsenyi wants to merge 1 commit intoinveniosoftware:masterfrom
Conversation
* Added a new class to define a policy for whether a new version draft of an existing record should trigger a community submission request. * The default behaviour is to never trigger a request for new versions (which is the current behaviour). * The implementation of this policy will come in later PRs. * The configured policy can be changed easily using a new config variable by inheriting from the class and overriding the method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2305
I am happy to make changes to the structure of this config or the general approach to the task of allowing per-record-version reviews. We should try to make changes now before we "lock in" the structure of the config.
See the discussion for more details.