fix(communities): return 400 on malformed community id#2352
Open
slint wants to merge 1 commit into
Open
Conversation
* A non-string `id` (e.g. `{}`) failed nested field validation, but the
uniqueness check ran via `@validates("communities")` on the partially
loaded list and crashed with `KeyError: 'id'`, returning a 500.
marshmallow runs `@validates` field validators unconditionally, even on
items that failed deserialization. Moved the count and uniqueness checks
to a field `validate=[...]` callable, which runs only after every item
deserialized, so a malformed entry surfaces as the nested 400 instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
id(e.g.{}) failed nested field validation, but theuniqueness check ran via
@validates("communities")on the partiallyloaded list and crashed with
KeyError: 'id', returning a 500.marshmallow runs
@validatesfield validators unconditionally, even onitems that failed deserialization. Moved the count and uniqueness checks
to a field
validate=[...]callable, which runs only after every itemdeserialized, so a malformed entry surfaces as the nested 400 instead.