fix(CreatibutorsField): Mount CreatibutorsModal only when opened#2353
Merged
kpsherva merged 1 commit intoJun 11, 2026
Merged
Conversation
kpsherva
reviewed
Jun 9, 2026
| addLabel, | ||
| editLabel, | ||
| initialCreatibutor, | ||
| displayName, |
Contributor
There was a problem hiding this comment.
I think we should leave this as a prop, because people might have already overridden this component and removing it will require a major release, since you are changing the function interface. I would leave it as a param, and in case the value is given - us the value, otherwise use creatibutorNameDisplay(initialCreatibutor), like you do in L63
Contributor
Author
There was a problem hiding this comment.
Yeah, you're right. Thanks! Updated!
* This change fixes the Creator/Contributor section in the deposit form where every CreatibutorsFieldItem unconditionally rendered a CreatibutorsModal, and inside each modal the Formik instance with enableReinitialize and a Yup schema instantiated at class-definition time for each author/creator, which led to every stroke triggering a redraw and re-mount for all the modals
sakshamarora1
force-pushed
the
fix/deposit_form_rendering
branch
from
42e996c to
87cf960
Compare
kpsherva
approved these changes
Jun 11, 2026
github-project-automation
Bot
moved this from In review 🔍
to To release 🤖
in Sprint Q2 2026 ☀️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly addresses: inveniosoftware/invenio-app-rdm#3006