fix(get_record_requests): allow anonymous users to access landing page#2363
Merged
utnapischtim merged 1 commit intoJun 12, 2026
Merged
Conversation
fenekku
approved these changes
Jun 12, 2026
fenekku
left a comment
fenekku
left a comment
Contributor
There was a problem hiding this comment.
Thanks! I think keeping the type(identity) == AnonymousIdentity is fine for now mostly because we don't have the bandwidth to investigate the ramifications and original context for that. In the future, it would be nice to verify, because I agree it seems redundant.
| self.require_permission(identity, "review", record=record._record) | ||
| can_review = self.check_permission(identity, "review", record=record._record) | ||
| if not can_review: | ||
| # Instead of raising PermissionDeniedError, return an empty dictionary because anonymous users do not have permissions to search requests |
Contributor
There was a problem hiding this comment.
minor: I would have thought the linter would flag those
Suggested change
| # Instead of raising PermissionDeniedError, return an empty dictionary because anonymous users do not have permissions to search requests | |
| # Instead of raising PermissionDeniedError, return an empty | |
| # dictionary because anonymous users do not have permissions to | |
| # search requests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.