refactor: remove context usage #647
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utnapischtim
commented
Sep 17, 2025
| context = {**base_context} | ||
| default_identity = context["identity"] # identity required in context | ||
| def set_field_permission_check(self, context): | ||
| default_identity = context_identity.get() |
Contributor
Author
There was a problem hiding this comment.
this one is wrong, it does not use the context["identity"] as the first option, context_identity.get() should be the fallback
utnapischtim
commented
Sep 17, 2025
| base_context = context or {} | ||
| context = self._build_context(base_context) | ||
| return self.schema(context=context, **schema_args).dump(data) | ||
| self.set_field_permission_check(context) |
Contributor
Author
There was a problem hiding this comment.
wrap it with a ContextManager
Contributor
Author
There was a problem hiding this comment.
token = context_identity.set(context[identity])
try:
self.set_field_permission_check(context)
return self.schema(**schema_args).dump(data)
finally:
context_identity.reset(None)
* marshmallow deprecated the context usage. * this commit introduces two ContextVars to replace the marshmallow context
utnapischtim
force-pushed
the
remove-context-usage
branch
from
5597997 to
6efe976
Compare
Contributor
Author
|
closed in favor of #653 if the problems should be handled independently, please update this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
marshmallow deprecated the context usage.
this commit introduces two ContextVars to replace the marshmallow context
needs:
inveniosoftware/invenio-access#222
inveniosoftware/marshmallow-utils#101