fix datetime utc warning #323
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utnapischtim
force-pushed
the
fix-datetime-utc-warning
branch
6 times, most recently
from
d018e6c to
48eba24
Compare
utnapischtim
force-pushed
the
fix-datetime-utc-warning
branch
2 times, most recently
from
a56fb09 to
4a86350
Compare
* datetime.utcnow is deprecated, change to datetime.now(timezone.utc) * arrow.utcnow() not necessary datetime.now(timezone.utc) does the same * Draft4Validator, API changed, required needs to be a function now * pytest-black -> pytest-black-ng former unsupported * catch expected deprecation warnings to not pop up in logs and to make it more predictable after removing the deprecation warnings from the code * the datetime has already set the tz_info. pytz is not necessary anymore
utnapischtim
force-pushed
the
fix-datetime-utc-warning
branch
from
4a86350 to
9c630de
Compare
Contributor
|
brief summary of what we just discussed IRL (reason for moving to the "to discuss" column): |
10 tasks
Contributor
Author
|
closed, super seeded by #342 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reviewers:
i am not sure about the change from pytz to datetime object itself: https://github.com/inveniosoftware/invenio-records/pull/323/files#diff-469dc6e514838423126b5d9cb7f8a97cb5d024fd648dd95a3be624c49a7e720bL99 my problem is that i don't know why the value in this
_serializemethod now has thetz_infoset already. it could be because of the change fromdatetime.utcnowtodatetime.now(UTC)but i am not sureQUESTION:
i tried to remove the
SQLALCHEMY_DATABASE_URIvariable from the test.yml file, but it didn't work. there are other packages out there which don't need this variable. why is it that this packages needs this variable. the problem was, that mysql used the postgresql URI without setting the mysql URI explicitly