Skip to content

Conversation

@SilvyPuzzlewell
Copy link

@SilvyPuzzlewell SilvyPuzzlewell commented Nov 19, 2025

Description

During initialization of invenio_requests request types, event types and entity references are loaded from entrypoints to the respective registries. There was a copypaste error in init_registry that caused that event type entrypoints were loaded incorrectly into request type registry. This patch fixes it by using the correct registry.

Tests were added to show that all entrypoints are loaded correctly.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@SilvyPuzzlewell SilvyPuzzlewell force-pushed the contribution-event-registry branch 2 times, most recently from cee6834 to 3978df4 Compare November 19, 2025 13:33
* There was a copypaste mistake in ext - event type entrypoints
  were loaded into the request type registry
* The fix replaces it with the correct registry and adds tests
  that demonstrate that correct registries are filled by
  entrypoints
@SilvyPuzzlewell SilvyPuzzlewell force-pushed the contribution-event-registry branch from 3978df4 to 40bdfbb Compare November 19, 2025 14:56
@utnapischtim utnapischtim moved this to 👀 In review in vNext Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

1 participant