Skip to content

fix(timeline): resize detection for comment body#579

Merged
zzacharo merged 1 commit intoinveniosoftware:maint-v11.xfrom
palkerecsenyi:fix-resize-detection
Feb 19, 2026
Merged

fix(timeline): resize detection for comment body#579
zzacharo merged 1 commit intoinveniosoftware:maint-v11.xfrom
palkerecsenyi:fix-resize-detection

Conversation

@palkerecsenyi
Copy link
Member

@palkerecsenyi palkerecsenyi commented Feb 19, 2026

Merging into maint-v11.x since this is a bug fix for features already on that branch. After merging, I will cherry pick to include in #578.

  • Before, if the size of the body changed after initial load, we wouldn't reevaluate whether it was overflowing and therefore whether a "show more" button needed to be shown.

  • Added a ResizeObserver to detect the size changes. If the button is clicked, the ResizeObserver is deactivated to avoid an infinite loop.

* Before, if the size of the body changed after initial load, we
wouldn't reevaluate whether it was overflowing and therefore whether a
"show more" button needed to be shown.

* Added a ResizeObserver to detect the size changes. If the button is
clicked, the ResizeObserver is deactivated to avoid an infinite loop.
Copy link
Contributor

@OliverGeneser OliverGeneser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zzacharo zzacharo merged commit e88c3cd into inveniosoftware:maint-v11.x Feb 19, 2026
@github-project-automation github-project-automation bot moved this from In review 🔍 to To release 🤖 in Sprint Q1/2026 Feb 19, 2026
@palkerecsenyi palkerecsenyi deleted the fix-resize-detection branch February 19, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To release 🤖

Development

Successfully merging this pull request may close these issues.

3 participants

Comments