Skip to content

fix: allow username to be omitted #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mesemus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: allow username to be omitted #207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions invenio_users_resources/records/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,16 +125,17 @@ def _validate_user_data(user_data):
`commit` state of the UOW and the feedback to the form can't be sent.
"""
errors = {}
username = user_data["username"]
username = user_data.get("username")
email = user_data["email"]
# Check if Email exists already
existing_email = db.session.query(User).filter_by(email=email).first()
if existing_email:
errors["email"] = [_("Email already used by another account.")]
# Check if Username exists already
existing_username = db.session.query(User).filter_by(username=username).first()
if existing_username:
errors["username"] = [_("Username already used by another account.")]
if username is not None:
existing_username = db.session.query(User).filter_by(username=username).first()
if existing_username:
errors["username"] = [_("Username already used by another account.")]
if errors:
raise ValidationError(errors)

Expand Down
Loading