All vocabularies endpoint and Admin interface#310
Merged
slint merged 28 commits intoinveniosoftware:masterfrom Jul 10, 2024
Merged
All vocabularies endpoint and Admin interface#310slint merged 28 commits intoinveniosoftware:masterfrom
slint merged 28 commits intoinveniosoftware:masterfrom
Conversation
slint
approved these changes
May 23, 2024
Member
slint
left a comment
slint
left a comment
There was a problem hiding this comment.
Looks good, some nits and minor comments (and possibly non-important things we shelve in issues).
Member
Author
|
depends on inveniosoftware/invenio-administration#208 |
10 tasks
SarahW91
force-pushed
the
all_vocabularies_endpoint
branch
from
b782db9 to
a5e1f90
Compare
Contributor
|
I added Uni Münster in the copyright header in the files where we added larger changes. Hope that's okay, otherwise I can remove it again. |
slint
approved these changes
Jun 19, 2024
Member
slint
left a comment
slint
left a comment
There was a problem hiding this comment.
Thanks a lot for the clean-up and splitting up the resource and service configs. I think this is looking good and most of my comments are about naming or removing duplicated or redundant config vars and attributes.
I know it's a lot of comments, so if you prefer we could also organize a quick call and go through some of the heavier ones together.
Co-authored-by: mkloeppe <mkloeppe@users.noreply.github.com>
… working properly.
…nd results in different files and cleaned up code.
SarahW91
force-pushed
the
all_vocabularies_endpoint
branch
from
842f5c3 to
e6ff95a
Compare
Samk13
reviewed
Jul 4, 2024
carlinmack
added a commit
to carlinmack/zenodo-rdm
that referenced
this pull request
Jul 17, 2024
📁 invenio-administration (2.4.0 -> 2.4.1 ��)
📦 release: v2.4.1
global: remove dependency on invenio-vocabularies
* Removes the dependency from invenio-vocabularies.
* Delegates administration UI schema type definition to the mashmallow
class.
📁 invenio-app-rdm (13.0.0b0.dev6 -> 13.0.0b0.dev8 )
📦 release: v13.0.0b0.dev8
previewer: gracefuly handle default preference
📦 release: v13.0.0b0.dev7
datastreams: add affiliations and update funders
📁 invenio-banners (3.0.1 -> 3.0.2 🐛)
release: v3.0.2
errors: fix validation errors not propagated to resource
administration: set default category to info
* Fixes inveniosoftware/invenio-banners#26 by setting default category value,
which is a required field.
📁 invenio-rdm-records (11.3.1 -> 11.4.0 🌈)
📦 release: v11.4.0
affiliations: update defaults to ror v2
📁 invenio-rest (1.3.0 -> 1.3.1 🐛)
release: v1.3.1
tests; fix csrf tests
csrf: improve validation
* inveniosoftware/invenio-rest#132
📁 invenio-vocabularies (4.0.0 -> 4.1.1 🌈)
📦 release: v4.1.1
installation: use invenio-oaipmh-scythe from PyPI
📦 release: v4.1.0
readers: make OAI-PMH an optional extra
schema: add administration UI attributes
ror: fix duplicate acronymns and aliases
affiliations: fix title search
datastreams: have yaml writer output utf8
datastreams: add configs for funders and affiliations
affiliations: add datastreams
datastreams: move ror transformer to common
affiliations: add new fields
vocabulary-types: services, resources, and administration UI (inveniosoftware/invenio-vocabularies#310)
config: add OpenAIRE mapping for "Latvian Council of Science"
tasks: fixed exception logging
funding: update award label
funders: fix country name display (inveniosoftware/invenio-vocabularies#343)
first implementation of OAIPMHReader (inveniosoftware/invenio-vocabularies#329)
* first implementation of OAIPMHReader
* introduce a simple way to map OAI records to a dict without expecting a special metadata format.
* fix installation requirements
* fix tests
* small fixes to make the tests run
* add error handling
* renamed oaipmh_scythe package
* handle remarks/questions from review.
* replaced access to a real OAI server with a mocking implementation.
* Update invenio_vocabularies/datastreams/readers.py
* Update tests/datastreams/test_datastreams.py
* Moved reader tests to testreaders.py
* add missing copyright in header
---------
global: add "tags" field to all vocabularies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Adresses #307
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: