Skip to content

react: Fix react dnd multiple HTML5backends bug #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JohannesLares wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

react: Fix react dnd multiple HTML5backends bug #509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...ries/assets/semantic-ui/js/invenio_vocabularies/src/contrib/forms/Funding/FundingField.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
// This file is part of InvenioVocabularies
// Copyright (C) 2021-2025 CERN.
// Copyright (C) 2021 Northwestern University.
// Copyright (C) 2025 CSC - IT Center for Science ltd.
//
// Invenio is free software; you can redistribute it and/or modify it
// under the terms of the MIT License; see LICENSE file for more details.

import React from "react";
import PropTypes from "prop-types";
import { FieldArray, getIn } from "formik";
import { HTML5Backend } from "react-dnd-html5-backend";
import { manager } from "@js/invenio_rdm_records";
Copy link
Contributor

@utnapischtim utnapischtim Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will not comment on the idea itself, because i am not into it at the moment, but here we have dependency issue. normally invenio-vocabulary is a dependency of invenio-rdm-records. reversing that now in the assets would create a circular dependency which can be complicated in the future. would it be possible to create the base manager somewhere else?

Copy link
Contributor

@utnapischtim utnapischtim Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could do what you did in invenio-rdm-records here and use it then in invenio-rdm-records

Copy link
Author

@JohannesLares JohannesLares Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reply, I did not notice that dependency issue. I'll swap the dependencies around regarding this change.

import { DndProvider } from "react-dnd";
import { Button, Form, Icon, List } from "semantic-ui-react";
import { FieldLabel, FeedbackLabel } from "react-invenio-forms";
Expand Down Expand Up @@ -95,7 +96,7 @@ function FundingFieldForm(props) {
}

return (
<DndProvider backend={HTML5Backend}>
<DndProvider manager={manager}>
<Form.Field required={required} className={className}>
<FieldLabel htmlFor={fieldPath} icon={labelIcon} label={label} />
<List>
Expand Down