replace deprecated usage of Link#517
Closed
fenekku wants to merge 3 commits intoinveniosoftware:masterfrom
Closed
Conversation
fenekku
commented
Nov 24, 2025
| "self": "https://127.0.0.1:5000/api/subjects/http://d-nb.info/gnd/1062531973" # noqa | ||
| } | ||
| # but they should still resolve | ||
| assert expected_links == res.json["links"] |
Contributor
Author
There was a problem hiding this comment.
This requires https://github.com/inveniosoftware/invenio-records-resources/pull/659/files to be merged and released
fenekku
commented
Jan 9, 2026
| @@ -0,0 +1,165 @@ | |||
| # -*- coding: utf-8 -*- | |||
Contributor
Author
There was a problem hiding this comment.
just combination of deleted test files above
max-moser
reviewed
Jan 14, 2026
Contributor
Author
|
comments addressed, I'll let @max-moser take another look to confirm |
max-moser
approved these changes
Jan 14, 2026
- remove generation of links for non-existing vocabulary type detail endpoint
fenekku
force-pushed
the
deprecate_link
branch
from
9e58b7a to
05e849c
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.