You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@inventree/triage I can not remember why we used Jinja2 instead of the normal templating engine - this removes our direct dependency on jinja2. This be breaking in some edge cases
I have a vague recollection that it was due to how we provide context for simple string rendering (e.g. for batch codes, order reference strings, filenames for generated reports). It looks like that is where the PR is failing currently.
If we can work around this and get those string rendering functions working, I'm happy to remove the dep and make this change
One difficulty here is that the jinja syntax we use in PART_NAME_FORMAT is incompatible with the django template syntax - so we will need to make a breaking change to that format string
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SchrodingersGat
force-pushed
the
move-to-default-engine
branch
from
Follow up to #10051 - moves file name rending to the default rendering engine instead of jinja2
This might be breaking in some cases