Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-backups.sh now check the status of the backup script #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dwlfrth
Copy link
Contributor

@dwlfrth dwlfrth commented Dec 14, 2016

Added a check in check-backups.sh for the output value of the database backup script.

Do not merge before merging inverse-inc/packetfence#1904

Take note of the "require root" attribute that was already present in this script. We may want to discuss this since the check won't run if do not have root permission even if that part of the check does not require root permissions.

Also, take note that PacketFence setups running a previous database-backup-and-maintenance script will throw an error.

@dwlfrth dwlfrth added the bug label Dec 14, 2016
@dwlfrth dwlfrth requested a review from julsemaan December 14, 2016 23:36
@julsemaan
Copy link
Collaborator

The thing with this PR is that it will fail unless the db maintenance script is updated but there is no check for an available update. Even worse, the update check can't apply to this as that script is often modified.

We can either:

  • Only exit fail if the file isn't there and the version is higher than 6.5 (which will have the updated script)
  • Not exit-fail if the backup status isn't there

Copy link
Collaborator

@julsemaan julsemaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problematic around status file existance

@CLAassistant
Copy link

CLAassistant commented Jul 16, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Derek Wuelfrath seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants