Fix logrotate check #8
Conversation
|
Review me and regenerate monit script once merged |
|
Bump |
|
TIL @jrouzierinverse listen to Ed Sheeran |
|
Not by choice I do have a daughter |
|
Of course, blame it on the daughter since she don't have a Github account which means she can't defend herself ! |
|
Your point is?
James Rouzier
[email protected] :: +1.514.447.4918 (x115) :: http://www.inverse.ca
Inverse inc. :: Leaders behind SOGo (http://www.sogo.nu) and PacketFence (http://www.packetfence.org)
…On 2016-12-16 11:06 AM, Derek Wuelfrath wrote:
Of course, blame it on the daughter since she don't have a Github
account which means she can't defend herself !
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACmeMYh1uG-AgF6iJ1iu5vyskopDfPaqks5rIrcbgaJpZM4LJGdf>.
|
|
I saw your Spotify history ;) |
|
That is funny I don't even have spotify
James Rouzier
[email protected] :: +1.514.447.4918 (x115) :: http://www.inverse.ca
Inverse inc. :: Leaders behind SOGo (http://www.sogo.nu) and PacketFence (http://www.packetfence.org)
…On 2016-12-16 11:09 AM, Derek Wuelfrath wrote:
I saw your Spotify history ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACmeMTxwiWiV9TJaGf7oViayjhvlpiygks5rIreggaJpZM4LJGdf>.
|
|
Then imagine how good Derek is to find intel! |
|
So that is where Trump got all his facts from.
Well Derek and the Russians
James Rouzier
[email protected] :: +1.514.447.4918 (x115) :: http://www.inverse.ca
Inverse inc. :: Leaders behind SOGo (http://www.sogo.nu) and PacketFence (http://www.packetfence.org)
…On 2016-12-16 11:17 AM, Julien Semaan wrote:
@jrouzierinverse <https://github.com/jrouzierinverse>
Then imagine how good Derek is to find intel!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACmeMVdUQVVHtTBqKbZuT_Da3ca5uqLFks5rIrmvgaJpZM4LJGdf>.
|
|
Chuuut. Don't tell. |
|
Soo I think that PR got the attention it was waiting for. What about reviewing it now ? ;) |
Ha! you're funny. That's not what Github is for... |
| @@ -34,11 +38,11 @@ fi | |||
| # Check for PacketFence logrotate script update against maintenance branch | |||
| # Checks the '/etc/logrotate.d/packetfence' file | |||
| pfversion | |||
| base_url="https://raw.githubusercontent.com/inverse-inc/packetfence/maintenance/$MAINTENANCE_VERSION" | |||
| latest=$(curl -s -L $base_url/packetfence.logrotate) | |||
| latest_url="https://raw.githubusercontent.com/inverse-inc/packetfence/maintenance/$MAINTENANCE_VERSION/packetfence.logrotate" | |||
There was a problem hiding this comment.
I am not familiar with the scripts framework.
Is the script functions.sh loaded in by some master process.
So the pfversion function can be used.
Or should functions.sh should be loaded in manually?
There was a problem hiding this comment.
It is loaded by a "master" process
There was a problem hiding this comment.
| @@ -25,6 +25,10 @@ fi | |||
|
|
|||
| # Check PacketFence logrotate script status | |||
| # Checks the '/usr/local/pf/var/logrotate.status' file | |||
| if ! [ -f /usr/local/pf/var/logrotate.status ]; then | |||
There was a problem hiding this comment.
You should proceed with the success checks after validating the version of the logrotate script.
Otherwise it fails with logrotate status file doesn't exist and calling logrotate with the outdated script won't change anything unless you first update it
This way, the user will first see he needs to update the script, then it will fail with status file not found which he can fix by calling the rotation manually
|
Can you perform the requested changes to this as everytime github cdn has capacity issues, this triggers a false positive alert |
|
Which changeS are we talking about ? |
|
Its a change sorry, I just blindly said changes and don't bother speeding this up as it doesn't fix the curl return code issue |
|
Derek Wuelfrath seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Check if status file exists rather than assuming it exists and fails with an awk error