Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds additional field for better troubleshooting in ntlm auth api. #8567

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

stgmsa
Copy link
Contributor

@stgmsa stgmsa commented Feb 25, 2025

Description

logs the "machine account" and Domain Controller when authenticate a user.

Impacts

Additional debugging/ warning log entries added.

Delete branch after merge

YES

Checklist

(REQUIRED) - [yes, no or n/a]

  • [no] Document the feature
  • [no] Add OpenAPI specification
  • [no] Add unit tests
  • [no] Add acceptance tests (TestLink)

Enhancements

  • added additional log field for ntlm authenticating request, selected domain controller and machine account will be logged.

@stgmsa stgmsa requested review from satkunas and lzammit February 25, 2025 16:10
@stgmsa
Copy link
Contributor Author

stgmsa commented Feb 25, 2025

backport needed -> to 14.1

Copy link
Contributor

@lzammit lzammit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thanks.

@stgmsa stgmsa merged commit 0942a5b into devel Feb 25, 2025
13 checks passed
@stgmsa stgmsa deleted the fix/ntlm-auth-log branch February 25, 2025 19:32
stgmsa added a commit that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants