haproxy-portal: listen only on interfaces configured for portal #8581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--publish` is ignored in context `--network=host` inverse-inc#8539 (comment)
Don't listen on interfaces a portal is not expected on. Bind explicitly to IPs of interfaces of types that are documented to contain the portal. inverse-inc#8539 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
haproxy-portal is configured to only listen on IPs of interfaces that are configured to provide the portal. The docker wrapper script is changed to not contain ignored parameters to
--publishports.Impacts
haproxy for portal will not listen to *:80 and *:443 anymore, but to the IPs of the interfaces configured to have portals listen on them.
Issue
fixes #8539
Delete branch after merge
YES
Checklist
Enhancements