Skip to content

Upgrade analyzer, analyzer_plugin, source_gen #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rrousselGit merged 14 commits into from
Jan 8, 2025
Merged

Upgrade analyzer, analyzer_plugin, source_gen #300

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
40aa953
Upgrade analyzer, analyzer_plugin, source_gen, and melos
Rexios80 Dec 20, 2024
232ebd1
Lock analyzer dependency in custom_lint_visitor
Rexios80 Dec 20, 2024
c577bdf
Fixing issues
Rexios80 Jan 6, 2025
bca1365
Revert melos upgrade
Rexios80 Jan 6, 2025
373bedd
Remove freezed override
Rexios80 Jan 6, 2025
26975ca
Regenerate with new freezed
Rexios80 Jan 6, 2025
283bb2e
Regenerate
Rexios80 Jan 7, 2025
97d247c
Exclude custom_lint_analyzer_plugin_loader from melos workspace
Rexios80 Jan 7, 2025
8e5d4b4
Update
rrousselGit Jan 8, 2025
09d46eb
Remove custom_lint_visitor override
rrousselGit Jan 8, 2025
63d5a8f
Another
rrousselGit Jan 8, 2025
d64163d
Merge branch 'main' of https://github.com/invertase/dart_custom_lint …
rrousselGit Jan 8, 2025
7e321f8
Fix tests
rrousselGit Jan 8, 2025
6f2b297
Changelog
rrousselGit Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/custom_lint/example/example_lint/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ environment:
sdk: '>=3.0.0 <4.0.0'

dependencies:
analyzer: ">=5.12.0 <7.0.0"
analyzer_plugin: ^0.11.2
analyzer: ">=5.12.0 <8.0.0"
analyzer_plugin: ^0.12.0
custom_lint_builder:
path: ../../../custom_lint_builder

Expand Down
6 changes: 4 additions & 2 deletions packages/custom_lint/example/example_lint/pubspec_overrides.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
# melos_managed_dependency_overrides: custom_lint,custom_lint_builder,custom_lint_core
# melos_managed_dependency_overrides: custom_lint,custom_lint_builder,custom_lint_core,custom_lint_visitor
dependency_overrides:
custom_lint:
path: ../../../custom_lint
path: ../..
custom_lint_builder:
path: ../../../custom_lint_builder
custom_lint_core:
path: ../../../custom_lint_core
custom_lint_visitor:
path: ../../../custom_lint_visitor
6 changes: 4 additions & 2 deletions packages/custom_lint/example/pubspec_overrides.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
# melos_managed_dependency_overrides: custom_lint,custom_lint_builder,custom_lint_core,custom_lint_example_lint
# melos_managed_dependency_overrides: custom_lint,custom_lint_builder,custom_lint_core,custom_lint_example_lint,custom_lint_visitor
dependency_overrides:
custom_lint:
path: ../../custom_lint
path: ..
custom_lint_builder:
path: ../../custom_lint_builder
custom_lint_core:
path: ../../custom_lint_core
custom_lint_example_lint:
path: example_lint
custom_lint_visitor:
path: ../../custom_lint_visitor
4 changes: 2 additions & 2 deletions packages/custom_lint/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ environment:
sdk: ">=3.0.0 <4.0.0"

dependencies:
analyzer: ^6.6.0
analyzer_plugin: ^0.11.0
analyzer: ^7.0.0
analyzer_plugin: ^0.12.0
args: ^2.3.1
async: ^2.9.0
ci: ^0.1.0
Expand Down
4 changes: 3 additions & 1 deletion packages/custom_lint/pubspec_overrides.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# melos_managed_dependency_overrides: custom_lint_core
# melos_managed_dependency_overrides: custom_lint_core,custom_lint_visitor
dependency_overrides:
custom_lint_core:
path: ../custom_lint_core
custom_lint_visitor:
path: ../custom_lint_visitor
8 changes: 8 additions & 0 deletions packages/custom_lint/tools/analyzer_plugin/pubspec_overrides.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# melos_managed_dependency_overrides: custom_lint,custom_lint_core,custom_lint_visitor
dependency_overrides:
custom_lint:
path: ../..
custom_lint_core:
path: ../../../custom_lint_core
custom_lint_visitor:
path: ../../../custom_lint_visitor
4 changes: 2 additions & 2 deletions packages/custom_lint_builder/example/example_lint/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ environment:
sdk: '>=3.0.0 <4.0.0'

dependencies:
analyzer: ^6.6.0
analyzer_plugin: ^0.11.2
analyzer: ^7.0.0
analyzer_plugin: ^0.12.0
custom_lint_builder:
path: ../../../custom_lint_builder
4 changes: 3 additions & 1 deletion packages/custom_lint_builder/example/example_lint/pubspec_overrides.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
# melos_managed_dependency_overrides: custom_lint,custom_lint_builder,custom_lint_core
# melos_managed_dependency_overrides: custom_lint,custom_lint_builder,custom_lint_core,custom_lint_visitor
dependency_overrides:
custom_lint:
path: ../../../custom_lint
custom_lint_builder:
path: ../..
custom_lint_core:
path: ../../../custom_lint_core
custom_lint_visitor:
path: ../../../custom_lint_visitor
6 changes: 4 additions & 2 deletions packages/custom_lint_builder/example/pubspec_overrides.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
# melos_managed_dependency_overrides: custom_lint,custom_lint_builder,custom_lint_builder_example_lint,custom_lint_core
# melos_managed_dependency_overrides: custom_lint,custom_lint_builder,custom_lint_builder_example_lint,custom_lint_core,custom_lint_visitor
dependency_overrides:
custom_lint:
path: ../../custom_lint
custom_lint_builder:
path: ../../custom_lint_builder
path: ..
custom_lint_builder_example_lint:
path: example_lint
custom_lint_core:
path: ../../custom_lint_core
custom_lint_visitor:
path: ../../custom_lint_visitor
4 changes: 2 additions & 2 deletions packages/custom_lint_builder/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ environment:
sdk: ">=3.0.0 <4.0.0"

dependencies:
analyzer: ^6.6.0
analyzer_plugin: ^0.11.0
analyzer: ^7.0.0
analyzer_plugin: ^0.12.0
collection: ^1.16.0
# Using tight constraints as custom_lint_builder communicate with each-other
# using a specific contract
Expand Down
3 changes: 3 additions & 0 deletions packages/custom_lint_builder/pubspec_overrides.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
# melos_managed_dependency_overrides: custom_lint_visitor
dependency_overrides:
custom_lint:
path: ../custom_lint
custom_lint_core:
path: ../custom_lint_core
custom_lint_visitor:
path: ../custom_lint_visitor
lint_visitor_generator:
path: ../lint_visitor_generator
4 changes: 2 additions & 2 deletions packages/custom_lint_core/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ environment:
sdk: ">=3.0.0 <4.0.0"

dependencies:
analyzer: ^6.7.0
analyzer_plugin: ^0.11.0
analyzer: ^7.0.0
analyzer_plugin: ^0.12.0
collection: ^1.16.0
custom_lint_visitor: ^1.0.0
glob: ^2.1.2
Expand Down
4 changes: 3 additions & 1 deletion packages/custom_lint_core/pubspec_overrides.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# melos_managed_dependency_overrides: lint_visitor_generator
# melos_managed_dependency_overrides: lint_visitor_generator,custom_lint_visitor
dependency_overrides:
custom_lint:
path: ../custom_lint
custom_lint_visitor:
path: ../custom_lint_visitor
lint_visitor_generator:
path: ../lint_visitor_generator
2 changes: 1 addition & 1 deletion packages/custom_lint_visitor/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ environment:
sdk: ">=3.0.0 <4.0.0"

dependencies:
analyzer: 6.11.0
analyzer: ^7.0.0
Copy link
Collaborator

@rrousselGit rrousselGit Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tight version is mandatory here.
And you need to re-run the generator

Copy link
Contributor Author

@Rexios80 Rexios80 Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to land rrousselGit/freezed#1140 first

Copy link
Collaborator

@rrousselGit rrousselGit Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why a Freezed version is necessary for custom_lint

Copy link
Contributor Author

@Rexios80 Rexios80 Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because freezed also depends on anaylzer...


dev_dependencies:
build_runner: ^2.3.3
Expand Down
4 changes: 2 additions & 2 deletions packages/lint_visitor_generator/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ environment:
sdk: ">=3.0.0 <4.0.0"

dependencies:
analyzer: ^6.6.0
analyzer: ^7.0.0
build: ^2.3.1
build_config: ^1.1.0
collection: ^1.17.1
meta: ^1.7.0
source_gen: ^1.2.3
source_gen: ^2.0.0

dev_dependencies:
build_runner: ^2.2.0
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ publish_to: none
environment:
sdk: ">=3.0.0 <4.0.0"
dev_dependencies:
melos: ^3.0.0
melos: ^6.2.0