Fix static analysis issues in custom_lint

[mishkov]

Issue

When I run flutter analyze in my Flutter app I always see annoying output logs related to custom_lint package so I decided to fix the issue by this PR

Pub.dev ratings

Also this PR should increase pub.dev scores 😁

[vercel]

@mishkov is attempting to deploy a commit to the Invertase Team on Vercel.

A member of the Team first needs to authorize it.

[docs-page]

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/dart_custom_lint~301

Documentation is deployed and generated using docs.page.

[CLAassistant]

All committers have signed the CLA.

[rrousselGit]

This requires bumping the minimum version of various dependencies ; as the changes rely on new features.

Could you do that?

[mishkov]

I've bumped versions of related package. Also I've tried to run tests (on main branch and on my branch) but it fails with following output. Is it okay? Maybe I can fix it?

Test output (I've included only beginning)

% dart test test/
Building package executable...
Built test:test.
00:00 +0: loading test/fixes_test.dart Could not find a command named "/Users/mishkov/development/flutter/bin/cache/dart-sdk/bin/snapshots/frontend_server.dart.snapshot".

Usage: dart <command|dart-file> [arguments]

Global options:
-v, --verbose Show additional command output.
--version Print the Dart SDK version.
--enable-analytics Enable analytics.
--disable-analytics Disable analytics.
--suppress-analytics Disallow analytics for this dart * run without changing the analytics configuration.
-h, --help Print this usage information.

Available commands:
analyze Analyze Dart code in a directory.
compile Compile Dart to various formats.
create Create a new Dart project.
devtools Open DevTools (optionally connecting to an existing application).
doc Generate API documentation for Dart projects.
fix Apply automated fixes to Dart source code.
format Idiomatically format Dart source code.
info Show diagnostic information about the installed tooling.
pub Work with packages.
run Run a Dart program.
test Run tests for a project.

Run "dart help " for more information about a command.
See https://dart.dev/tools/dart-tool for detailed documentation.
00:00 +0 -1: loading test/fixes_test.dart [E]
Failed to load "test/fixes_test.dart":
00:00 +0 -2: loading test/cli_process_test.dart [E]
Failed to load "test/cli_process_test.dart":
00:00 +0 -2: loading test/fixes_test.dart [E]
SocketException: Write failed (OS Error: Broken pipe, errno = 32), port = 0
dart:io-patch/socket_patch.dart 1252:34 _NativeSocket.write
dart:io-patch/socket_patch.dart 2010:15 _RawSocket.write
dart:io-patch/socket_patch.dart 2487:18 _Socket._write
dart:io-patch/socket_patch.dart 2222:28 _SocketStreamConsumer.write
dart:io-patch/socket_patch.dart 2174:11 _SocketStreamConsumer.addStream.
dart:async/zone.dart 1422:47 _rootRunUnary
dart:async/zone.dart 1324:19 _CustomZone.runUnary
dart:async/zone.dart 1233:7 _CustomZone.runUnaryGuarded
dart:async/stream_impl.dart 366:11 _BufferingStreamSubscription._sendData
dart:async/stream_impl.dart 297:7 _BufferingStreamSubscription._add
dart:async/stream_controller.dart 777:19 _SyncStreamControllerDispatch._sendData
dart:async/stream_controller.dart 651:7 _StreamController._add
dart:async/stream_controller.dart 606:5 _StreamController.add
dart:io/io_sink.dart 154:17 _StreamSinkImpl.add
dart:io/io_sink.dart 287:5 _IOSinkImpl.write
dart:io-patch/socket_patch.dart 2320:36 _Socket.write
dart:io/stdio.dart 426:13 _StdSink.writeln
package:frontend_server_client/src/frontend_server_client.dart 328:21 FrontendServerClient._sendCommand
package:frontend_server_client/src/frontend_server_client.dart 245:5 FrontendServerClient.accept
package:test_core/src/runner/vm/test_compiler.dart 128:30 _TestCompilerForLanguageVersion._compile
===== asynchronous gap ===========================
package:pool/pool.dart 127:14 Pool.withResource
===== asynchronous gap ===========================
package:test_core/src/runner/vm/platform.dart 249:22 VMPlatform._compileToKernel
===== asynchronous gap ===========================
package:test_core/src/runner/vm/platform.dart 231:13 VMPlatform._spawnIsolate
===== asynchronous gap ===========================
package:test_core/src/runner/vm/platform.dart 76:19 VMPlatform.load
===== asynchronous gap ===========================
package:test_core/src/runner/loader.dart 232:27 Loader.loadFile.
===== asynchronous gap ===========================
package:test_core/src/runner/load_suite.dart 98:19 new LoadSuite..

00:00 +0 -3: loading test/error_report_test.dart [E]
Failed to load "test/error_report_test.dart":

[rrousselGit]

This has been sorted in a different PR, but thanks!