Skip to content

Comments

feat(custom_lint_core): Support workspaces#312

Merged
rrousselGit merged 4 commits intoinvertase:mainfrom
Rexios80:feature/workspaces
Feb 26, 2025
Merged

feat(custom_lint_core): Support workspaces#312
rrousselGit merged 4 commits intoinvertase:mainfrom
Rexios80:feature/workspaces

Conversation

@Rexios80
Copy link
Contributor

Resolves #298

@vercel
Copy link

vercel bot commented Feb 13, 2025

@Rexios80 is attempting to deploy a commit to the Invertase Team on Vercel.

A member of the Team first needs to authorize it.

@docs-page
Copy link

docs-page bot commented Feb 13, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/dart_custom_lint~312

Documentation is deployed and generated using docs.page.

@markbeij
Copy link

Just curious.. would restarting the build fix things or is it more complicated than that?

@Rexios80
Copy link
Contributor Author

@rrousselGit All tests pass locally. Not sure what's wrong with CI.

@rrousselGit
Copy link
Collaborator

It could be that your changes break tests only under some special conditions.

@Rexios80
Copy link
Contributor Author

@rrousselGit I'm confused how the get and upgrade build actions are even different. I don't see any checked in pubspec.lock files so shouldn't running pub get and pub upgrade result in the same dependency resolution?

@rrousselGit
Copy link
Collaborator

rrousselGit commented Feb 23, 2025

Hum that's a good call. Some of my repos may have mistakenly ignored the lock file

It probably doesn't matter here though

@rrousselGit rrousselGit merged commit 98c0ebc into invertase:main Feb 26, 2025
4 of 5 checks passed
@rrousselGit
Copy link
Collaborator

Let's go!
Thanks for this :)

Artur-Wisniewski pushed a commit to Artur-Wisniewski/dart_custom_lint that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

custom_lint does not work with pub workspaces

3 participants