Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/docs.page~455 Documentation is deployed and generated using docs.page. |
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant restructuring of the project, migrating from a Dart-based CLI to a Bun-based monorepo structure. It adds new documentation agent capabilities, including MCP server support and chat functionality, and updates the UI components to use a new Tailwind CSS configuration. I have identified a systematic syntax error in the Tailwind CSS arbitrary value usage across several new UI components (e.g., dropdown-menu.tsx, select.tsx, hover-card.tsx), where CSS variables are incorrectly referenced without the required square bracket syntax (e.g., max-h-(--radix-...) should be max-h-[var(--radix-...)]).
| sideOffset={sideOffset} | ||
| align={align} | ||
| className={cn( | ||
| "z-50 max-h-(--radix-dropdown-menu-content-available-height) w-(--radix-dropdown-menu-trigger-width) min-w-32 origin-(--radix-dropdown-menu-content-transform-origin) overflow-x-hidden overflow-y-auto rounded-lg bg-popover p-2 text-popover-foreground shadow-md ring-1 ring-foreground/10 duration-100 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 data-[state=closed]:overflow-hidden data-open:animate-in data-open:fade-in-0 data-open:zoom-in-95 data-closed:animate-out data-closed:fade-out-0 data-closed:zoom-out-95", |
There was a problem hiding this comment.
There appears to be a systematic syntax error in the Tailwind CSS class names for arbitrary values that use CSS variables. For example, max-h-(--radix-dropdown-menu-content-available-height) should be max-h-[var(--radix-dropdown-menu-content-available-height)].
The correct syntax uses square brackets [] to denote an arbitrary value and the var() CSS function to reference the custom property. This issue is present in this file and also in other new UI components like select.tsx and hover-card.tsx. Please review these components and correct the syntax.
2 participants
UI improvements on default theming
Old:
New:
