feat(android): Support data param in notification#1141
Open
aureosouza wants to merge 3 commits intoinvertase:mainfrom
Open
feat(android): Support data param in notification#1141aureosouza wants to merge 3 commits intoinvertase:mainfrom
aureosouza wants to merge 3 commits intoinvertase:mainfrom
Conversation
|
|
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1141 +/- ##
=======================================
Coverage 77.08% 77.08%
=======================================
Files 32 32
Lines 1727 1727
Branches 556 556
=======================================
Hits 1331 1331
Misses 395 395
Partials 1 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1081
This fix avoids the need of sending a second data-only notification, in a similar behavior as iOS. More info on firebase data payload here.
Based on discussions from #393 (comment) and using similar solution as here we are injecting the data param on the method getDisplayedNotifications.
Obs.: firebase needs to inject the data param as well, for this we added a handleIntent override for the class that extends FirebaseMessagingService, further PRs will be necessary on firebase side. In case of react-native-firebase there is more info here.