Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(firestore): add support for onSnapshotsInSync #8379

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SelaseKay
Copy link
Collaborator

@SelaseKay SelaseKay commented Feb 28, 2025

Description

Currently the firebase-js-sdk has an onSnapshotsInSync API and react-native-firebase does not

This PR (when complete) will close that feature gap)

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious - is this a namespace -> modular gap, or a feature gap between RNFB and firebase-js-sdk?

There's no info in the PR beyond the boilerplate template contents

@SelaseKay
Copy link
Collaborator Author

@mikehardy, it's a feature. onSnapshotsInSync is not supported in RNFB, both in the JS and natively. This PR is not complete.

@mikehardy
Copy link
Collaborator

Ah, thanks. I updated the description to match in case I take a peek again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants