feat: retry queue items #7649
Merged
feat: retry queue items #7649
+402
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retrying a queue item means cloning it, resetting all execution-related state. Retried queue items reference the item they were retried from by id. This relationship is not enforced by any DB constraints. - Add `retried_from_item_id` to `session_queue` table in DB in a migration. - Add `retry_items_by_id` method to session queue service. Accepts a list of queue item IDs and clones them (minus execution state). Returns a list of retried items. Items that are not in a canceled or failed state are skipped. - Add `retry_items_by_id` HTTP endpoint that maps 1-to-1 to the queue service method. - Add `queue_items_retried` event, which includes the list of retried items.
- Add the new HTTP endpoint to the queue client - Add buttons to the queue items to retry them
psychedelicious
requested review from
blessedcoolant,
maryhipp,
hipsterusername and
brandonrising
as code owners
github-actions
bot
added
api
python
hipsterusername
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add functionality to retry a failed or canceled queue item by copying it. See commits for details.
Related Issues / Discussions
Offline discussion
QA Instructions
Try it out. There's an awkward UX - once a queue item fails or is canceled, you can always retry it. Perhaps this should be disabled when it's been retried a certain number of times?
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)