Skip to content

fix(metadata): recall z_image_shift correctly #9139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pfannkuchensack wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −4
Open

fix(metadata): recall z_image_shift correctly #9139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions invokeai/frontend/web/src/features/metadata/parsing.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,20 +785,35 @@ const QwenImageShift: SingleMetadataHandler<number | null> = {
//#endregion QwenImageShift

//#region ZImageShift
const ZImageShift: SingleMetadataHandler<number> = {
const ZImageShift: SingleMetadataHandler<number | null> = {
[SingleMetadataKey]: true,
type: 'ZImageShift',
parse: (metadata, _store) => {
parse: (metadata, store) => {
const raw = getProperty(metadata, 'z_image_shift');
const parsed = z.number().min(0).max(3).parse(raw);
if (raw === undefined) {
// Older Z-Image images and new images generated with auto shift don't include this key.
// Recall as null (auto) only when the recalled image is a Z-Image, so we don't clobber
// the user's current shift when recalling unrelated metadata.
const base = selectBase(store.getState());
if (base !== 'z-image') {
return Promise.reject();
}
return Promise.resolve(null);
}
if (raw === null) {
return Promise.resolve(null);
}
const parsed = z.number().min(0).max(10).parse(raw);
return Promise.resolve(parsed);
},
recall: (value, store) => {
store.dispatch(setZImageShift(value));
},
i18nKey: 'metadata.zImageShift',
LabelComponent: MetadataLabel,
ValueComponent: ({ value }: SingleMetadataValueProps<number>) => <MetadataPrimitiveValue value={value} />,
ValueComponent: ({ value }: SingleMetadataValueProps<number | null>) => (
<MetadataPrimitiveValue value={value ?? 'Auto'} />
),
};
//#endregion ZImageShift

Expand Down
Loading