Investigate and clarify ESM module settings trailing comma issue#1281
Draft
Copilot wants to merge 1 commit intoclaude/fix-issue-1127-01PCszX1jdWVVsH7e1qptjyifrom
Draft
Investigate and clarify ESM module settings trailing comma issue#1281Copilot wants to merge 1 commit intoclaude/fix-issue-1127-01PCszX1jdWVVsH7e1qptjyifrom
Copilot wants to merge 1 commit intoclaude/fix-issue-1127-01PCszX1jdWVVsH7e1qptjyifrom
Conversation
8 tasks
Copilot
AI
changed the title
[WIP] Fix ESM module settings in create-adapter PR
Investigate and clarify ESM module settings trailing comma issue
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist:
npm run buildnpm test.github/create_templates.ts)docs/updatesexplaining what the user needs to do when manually updating an existing projectCHANGELOG.md(referencing the migration description and this PR or the issue you fixed)Description:
Addresses review comment from #1255 regarding a reported missing trailing comma in the ESM module settings block at
templates/tsconfig.json.ts:49.Investigation Results:
Line 49 contains
"noEmit": true,with a trailing comma present. Tested JSON generation across multiple scenarios:All scenarios generate valid JSON. The template string interpolation correctly preserves commas:
Awaiting clarification on specific case that produces invalid JSON.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.