Plus loophole in min version checks #1227
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve issue ioccc-src#1206. Some people wanted this option to submit multiple submissions without having to repeatedly copy/paste the UUID. Now they can just put the UUID in a text file and use -u uuid. If the file is not a regular readable file or it does not have a valid UUID it'll prompt like before. If the -i answers flag is used it is not relevant. Resolve issue ioccc-src#1210. The directory/file lists to be ignored prompting was confusing to some people. The question of 'Is this OK?' was reworded to 'Do you wish to continue?' and the explanation is hopefully a bit clearer too. Resolve issue ioccc-src#1221. Removed the check for first rule is all (in Makefiles). This allows one to also have earlier on the format of 'CC:= cc' rather than just 'CC= cc', should they wish. The .info.json file still has this bool but it's always set to true and chkentry will ignore it. AFTER IOCCC28 it will be removed from .info.json and chkentry code will no longer have the functions involved. Resolve issue ioccc-src#1209. Although not labelled 'top priority' it was already done in the code. If topdir is the same as workdir it is an error. If workdir is under topdir it is an error. If topdir is somehow slipped into the submission directory it is an error. If workdir is encountered in topdir we skip it with fts_set() so as to not descend into it. Also, we now check that the directories are directories an are the right permissions, prior to even trying to scan/copy files/directories (to show a better error message). IMPORTANT NOTE: none of these will cause a previously uploaded submission to be invalidated. You do NOT need to install or use the updated tools. These are for those who want or need (or feel they need) the features (and fixes) only.
With guidance from @SirWumpus and Landon, and at their request, the iocccsize tool no longer warns against wordbuf warning unless verbosity is high enough; in mkiocccentry it sets the boolean to true or false depending on the result but it only notes it as a fun fact, suggesting the user note it in their remarks. Post IOCCC28 the bool will be removed from .info.json and chkentry(1) functions for it will be removed. For now the function that checks this value in chkentry(1) simply returns true. Additionally, the wrong variable was being referenced in soup/rule_count.c - it was referencing counts.wordbuf_warning when it should have been referencing counts.ungetc_error. Also, because rule 13 no longer restricts UTF the char warning is only shown if verbose enough. This did not need to be updated in mkiocccentry as it's only referenced #ifdef ASCII_ONLY and before that check is in soup/rule_count.c the code does #undef ASCII_ONLY (and it's not even referenced in mkiocccentry.c).
Added a max version too. This will prevent someone from having their own version that might not be released or official and it can be flagged (okay so they might still have a version in between but that's inconsequential). Updated gen_test_JSON.sh version to "1.0.3 2025-03-09".
|
Now I can finish the FAQ about this stuff. After that I'll be done for the day unless anything else comes up that you need me to address. |
|
Closing due to your excellent reminder @lcn2. I got it fixed on my end but by closing this one it's easy to do. Then I can also fix the FAQ over there - with a new commit. |
|
I believe it's all good over there too - and updated the log on GitHub. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a max version too. This will prevent someone from having their own
version that might not be released or official and it can be flagged
(okay so they might still have a version in between but that's
inconsequential).
Updated gen_test_JSON.sh version to "1.0.3 2025-03-09".