Sync jparse repo #1248
Merged
Sync jparse repo #1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync jparse repo (https://github.com/xexyl/jparse/) to jparse/. This fixes a potentially critical bug in sum_and_count() (used in txzchk(1)), man page updates and all the tools (only tools, no library related code) have early in main() a setlocale(LC_ALL, ""); to use the system's default locale based on LANG. Additionally a macro and variable were renamed to better reflect what they are (this does not affect any code in mkiocccentry however).
The 'bug' I had noticed yesterday was actually correct as it stood so I have added a comment to it now so that we don't stupidly change it again (as it appears that it breaks txzchk - a test case needs to be devised for this function apparently but that can happen another time).
Or consistency fix in case.
lcn2
approved these changes
Mar 15, 2025
You are most welcome. I added a comment to that 'fix' so something like that doesn't happen again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.