Skip to content

Remove redundant code for unsupported Python versions#300

Merged
ionelmc merged 2 commits intoionelmc:masterfrom
hugovk:rm-redundant-code
Feb 16, 2026
Merged

Remove redundant code for unsupported Python versions#300
ionelmc merged 2 commits intoionelmc:masterfrom
hugovk:rm-redundant-code

Conversation

@hugovk
Copy link
Contributor

@hugovk hugovk commented Feb 13, 2026

This package supports Python 3.9 and later.

This PR:

  • Removes some code for Python 2.5 and earlier.
  • Removes some code for Python 2.6 and earlier.
  • Removes compat.py which isn't used any more (since 8e735b2).

@ionelmc ionelmc merged commit c01feff into ionelmc:master Feb 16, 2026
157 of 159 checks passed
@hugovk hugovk deleted the rm-redundant-code branch February 16, 2026 14:18
@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.52%. Comparing base (b857483) to head (a679382).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
+ Coverage   90.46%   90.52%   +0.05%     
==========================================
  Files          29       28       -1     
  Lines        2938     2934       -4     
  Branches      318      318              
==========================================
- Hits         2658     2656       -2     
+ Misses        206      204       -2     
  Partials       74       74              
Flag Coverage Δ
py310-pytest84-nodist-cover (macos/arm64) 86.05% <100.00%> (+0.04%) ⬆️
py310-pytest84-nodist-cover (ubuntu/x64) 86.57% <100.00%> (+0.25%) ⬆️
py310-pytest84-nodist-cover (windows/x64) 85.61% <100.00%> (-0.16%) ⬇️
py310-pytest84-xdist-cover (macos/arm64) 86.36% <100.00%> (+0.04%) ⬆️
py310-pytest84-xdist-cover (ubuntu/x64) 86.67% <100.00%> (-0.16%) ⬇️
py310-pytest84-xdist-cover (windows/x64) 86.12% <100.00%> (+0.04%) ⬆️
py310-pytest90-nodist-cover (macos/arm64) 86.02% <100.00%> (+0.04%) ⬆️
py310-pytest90-nodist-cover (ubuntu/x64) 86.53% <100.00%> (+0.25%) ⬆️
py310-pytest90-nodist-cover (windows/x64) 85.58% <100.00%> (-0.16%) ⬇️
py310-pytest90-xdist-cover (macos/arm64) 86.33% <100.00%> (+0.04%) ⬆️
py310-pytest90-xdist-cover (ubuntu/x64) 86.63% <100.00%> (-0.19%) ⬇️
py310-pytest90-xdist-cover (windows/x64) 86.09% <100.00%> (+0.04%) ⬆️
py311-pytest84-nodist-cover (macos/arm64) 86.05% <100.00%> (+0.04%) ⬆️
py311-pytest84-nodist-cover (ubuntu/x64) 86.36% <100.00%> (+0.01%) ⬆️
py311-pytest84-nodist-cover (windows/x64) 85.82% <100.00%> (+0.04%) ⬆️
py311-pytest84-xdist-cover (macos/arm64) 86.36% <100.00%> (+0.04%) ⬆️
py311-pytest84-xdist-cover (ubuntu/x64) 86.67% <100.00%> (+0.01%) ⬆️
py311-pytest84-xdist-cover (windows/x64) 86.12% <100.00%> (+0.04%) ⬆️
py311-pytest90-nodist-cover (macos/arm64) 86.02% <100.00%> (+0.04%) ⬆️
py311-pytest90-nodist-cover (ubuntu/x64) 86.33% <100.00%> (-0.19%) ⬇️
py311-pytest90-nodist-cover (windows/x64) 85.78% <100.00%> (+0.04%) ⬆️
py311-pytest90-xdist-cover (macos/arm64) 86.33% <100.00%> (+0.04%) ⬆️
py311-pytest90-xdist-cover (ubuntu/x64) 86.63% <100.00%> (+0.01%) ⬆️
py311-pytest90-xdist-cover (windows/x64) 86.09% <100.00%> (+0.25%) ⬆️
py312-pytest84-nodist-cover (macos/arm64) 85.85% <100.00%> (-0.16%) ⬇️
py312-pytest84-nodist-cover (ubuntu/x64) 86.40% <100.00%> (-0.16%) ⬇️
py312-pytest84-nodist-cover (windows/x64) 85.82% <100.00%> (+0.04%) ⬆️
py312-pytest84-xdist-cover (macos/arm64) 86.36% <100.00%> (+0.04%) ⬆️
py312-pytest84-xdist-cover (ubuntu/x64) 86.70% <100.00%> (+0.04%) ⬆️
py312-pytest84-xdist-cover (windows/x64) 86.12% <100.00%> (+0.04%) ⬆️
py312-pytest90-nodist-cover (macos/arm64) 86.02% <100.00%> (+0.04%) ⬆️
py312-pytest90-nodist-cover (ubuntu/x64) 86.53% <100.00%> (+0.21%) ⬆️
py312-pytest90-nodist-cover (windows/x64) 85.78% <100.00%> (+0.04%) ⬆️
py312-pytest90-xdist-cover (macos/arm64) 86.33% <100.00%> (+0.04%) ⬆️
py312-pytest90-xdist-cover (ubuntu/x64) 86.63% <100.00%> (+0.04%) ⬆️
py312-pytest90-xdist-cover (windows/x64) 86.09% <100.00%> (+0.04%) ⬆️
py313-pytest84-nodist-cover (macos/arm64) 86.05% <100.00%> (+0.04%) ⬆️
py313-pytest84-nodist-cover (ubuntu/x64) 86.36% <100.00%> (-0.16%) ⬇️
py313-pytest84-nodist-cover (windows/x64) 85.82% <100.00%> (+0.25%) ⬆️
py313-pytest84-xdist-cover (macos/arm64) 86.36% <100.00%> (+0.04%) ⬆️
py313-pytest84-xdist-cover (ubuntu/x64) 86.67% <100.00%> (-0.19%) ⬇️
py313-pytest84-xdist-cover (windows/x64) 85.92% <100.00%> (+0.04%) ⬆️
py313-pytest90-nodist-cover (macos/arm64) 86.02% <100.00%> (+0.04%) ⬆️
py313-pytest90-nodist-cover (ubuntu/x64) 86.36% <100.00%> (+0.04%) ⬆️
py313-pytest90-nodist-cover (windows/x64) 85.58% <100.00%> (-0.16%) ⬇️
py313-pytest90-xdist-cover (macos/arm64) 86.33% <100.00%> (+0.04%) ⬆️
py313-pytest90-xdist-cover (ubuntu/x64) 86.67% <100.00%> (-0.16%) ⬇️
py313-pytest90-xdist-cover (windows/x64) 86.09% <100.00%> (+0.25%) ⬆️
py314-pytest84-nodist-cover (macos/arm64) 89.39% <100.00%> (+0.05%) ⬆️
py314-pytest84-nodist-cover (ubuntu/x64) 89.87% <100.00%> (+0.02%) ⬆️
py314-pytest84-nodist-cover (windows/x64) 89.12% <100.00%> (+0.05%) ⬆️
py314-pytest84-xdist-cover (macos/arm64) 89.70% <100.00%> (+0.05%) ⬆️
py314-pytest84-xdist-cover (ubuntu/x64) 90.01% <100.00%> (+0.05%) ⬆️
py314-pytest84-xdist-cover (windows/x64) 89.43% <100.00%> (+0.05%) ⬆️
py314-pytest90-nodist-cover (macos/arm64) 89.39% <100.00%> (+0.05%) ⬆️
py314-pytest90-nodist-cover (ubuntu/x64) 89.70% <100.00%> (+0.05%) ⬆️
py314-pytest90-nodist-cover (windows/x64) 89.12% <100.00%> (+0.05%) ⬆️
py314-pytest90-xdist-cover (macos/arm64) 89.70% <100.00%> (+0.05%) ⬆️
py314-pytest90-xdist-cover (ubuntu/x64) 90.01% <100.00%> (-0.12%) ⬇️
py314-pytest90-xdist-cover (windows/x64) 89.43% <100.00%> (+0.05%) ⬆️
py39-pytest84-nodist-cover (macos/arm64) 85.43% <100.00%> (+0.04%) ⬆️
py39-pytest84-nodist-cover (ubuntu/x64) 85.94% <100.00%> (+0.25%) ⬆️
py39-pytest84-nodist-cover (windows/x64) 85.19% <100.00%> (+0.04%) ⬆️
py39-pytest84-xdist-cover (macos/arm64) 85.74% <100.00%> (+0.04%) ⬆️
py39-pytest84-xdist-cover (ubuntu/x64) 86.28% <100.00%> (+0.28%) ⬆️
py39-pytest84-xdist-cover (windows/x64) 85.50% <100.00%> (+0.04%) ⬆️
pypy311-pytest84-nodist-cover (macos/arm64) 85.20% <100.00%> (+0.04%) ⬆️
pypy311-pytest84-nodist-cover (ubuntu/x64) 85.51% <100.00%> (+0.01%) ⬆️
pypy311-pytest84-nodist-cover (windows/x64) 84.76% <100.00%> (-0.16%) ⬇️
pypy311-pytest84-xdist-cover (macos/arm64) 85.51% <100.00%> (+0.04%) ⬆️
pypy311-pytest84-xdist-cover (ubuntu/x64) 85.82% <100.00%> (+0.01%) ⬆️
pypy311-pytest84-xdist-cover (windows/x64) ?
pypy311-pytest90-nodist-cover (macos/arm64) 85.20% <100.00%> (+0.04%) ⬆️
pypy311-pytest90-nodist-cover (ubuntu/x64) 85.51% <100.00%> (-0.19%) ⬇️
pypy311-pytest90-nodist-cover (windows/x64) 84.76% <100.00%> (-0.16%) ⬇️
pypy311-pytest90-xdist-cover (macos/arm64) 85.31% <100.00%> (-0.16%) ⬇️
pypy311-pytest90-xdist-cover (ubuntu/x64) 86.05% <100.00%> (+0.25%) ⬆️
pypy311-pytest90-xdist-cover (windows/x64) 85.07% <100.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments