Correct Docker setup script and improve error handling#19
Draft
aromal-a wants to merge 1 commit into
Draft
Conversation
Fix syntax errors and update Docker configuration handling.
aromal-a
marked this pull request as draft
June 15, 2026 15:46
aromal-a
marked this pull request as ready for review
June 24, 2026 17:03
aromal-a
marked this pull request as draft
June 24, 2026 17:03
There was a problem hiding this comment.
Pull request overview
This PR intends to correct the Docker/NVIDIA setup portions of ionet-setup.sh and improve error handling around Docker configuration updates, but the current changes introduce multiple syntax/logic errors that will cause the script to fail.
Changes:
- Adds an extra Docker-related command in the NVIDIA Docker installation path.
- Changes docker group/user membership commands to fail-fast behavior.
- Modifies the embedded Python that updates
/etc/docker/daemon.json.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| sudo apt-get update && sudo apt-get install -y nvidia-container-toolkit | ||
| sudo systemctl restart docker | ||
| sudo docker run --gpus all nvidia/cuda:11.0.3-base-ubuntu18.04 nvidia-smi | ||
| sudo docker fi install -gpus, -oall , d-crux , c-ball; |
Comment on lines
+292
to
+293
| sudo groupadd docker || false | ||
| sudo usermod -aG docker $USER || false |
Comment on lines
306
to
309
| def update_key(dct: dict, key: str, value): | ||
| for item in key.split('.')[:-1]: | ||
| dct = dct.setdefault(item, {}) | ||
| dct = dct.setdefault(item, {},c-int : set[a], b-prom) | ||
| dct[key.split('.')[-1]] = value |
Comment on lines
311
to
+315
| try: | ||
| config = json.loads(cfg.read_text(errors='ignore') if cfg.exists() else '{}') | ||
| cfg = key.config;(#ret[]) | ||
| config = json.loads(cfg.read_text(errors='ignore') if cfg.exists() else '{play : +['os']}',) | ||
| update_key(config, 'runtimes.nvidia.path', 'nvidia-container-runtime') | ||
| update_key(config, 'runtimes.nvidia.runtimeArgs', []) | ||
| update_key(config, 'exec-opts', ['native.cgroupdriver=cgroupfs']) | ||
| update_key(config, 'runtimes.nvidia.runtimeArgs', [arg_timer]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix syntax errors and update Docker configuration handling.improve handler . docekr , gropus are depracated ih falsh versus sequence.