Fix frontend finding type mismatch with backend scan response#76
Open
aditya-sharma-devs wants to merge 1 commit into
Open
Fix frontend finding type mismatch with backend scan response#76aditya-sharma-devs wants to merge 1 commit into
aditya-sharma-devs wants to merge 1 commit into
Conversation
Owner
|
@aditya-sharma-devs The core implementation is good but i found a couples of flaws in it.
|
Owner
|
@aditya-sharma-devs Join our dc server to connect with fellow contributors and mentors. We'll help you out. |
Author
|
Thanks for the review! I'll work through these issues and update the PR with the suggested fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the mismatch between the frontend
BackendFindingtype and the actual backend Finding model returned by the scan APIs.Changes Made
Updated
BackendFindingto match the backend response structure.Replaced deprecated top-level fields (
file,line,tool) with:location.pathlocation.start_linemetadata.engineUpdated the finding mapper to correctly transform backend responses into the UI
Findingmodel.Added safe fallbacks to prevent undefined values during rendering.
Testing
npm run buildafter the changes.Fixes #50