feat: add migrate-to-spm cli command

[markemer]

No description provided.

[jcesarmobile]

Added some comments.

Also:

• ios-spm-template already has the same files you created in the ios-spm-migrate-template, can't you use ios-spm-template files instead of a new ones?

• Do we need the --unsafe and --dry-run options? for --unsafe I assume people uses git or some other source control, so they could revert if they had some problem. And for --dry-run we are documenting the changes the command does so people can know.

• We have a separate ticket for the messaging/handling of non SPM plugins, so you can leave those changes out of the migration command.

[jcesarmobile]

Another thought, since it doesn't do a full migration, maybe it should be renamed to assist-spm-migration?

And at the end it should show a link to the SPM docs, to the ### Using our migration tool section once it's live.

[markemer]

Added some comments.

Also:

• ios-spm-template already has the same files you created in the ios-spm-migrate-template, can't you use ios-spm-template files instead of a new ones?
• Do we need the --unsafe and --dry-run options? for --unsafe I assume people uses git or some other source control, so they could revert if they had some problem. And for --dry-run we are documenting the changes the command does so people can know.
• We have a separate ticket for the messaging/handling of non SPM plugins, so you can leave those changes out of the migration command.

• I can look into the best way to use the template files - it might be trivial to do that.
• I'm gonna ditch --unsafe but keep --dry-run, I think
• Non SPM plugins will just throw a warning for now - but I don't want to give people the idea it worked when it didn't.

[markemer]

Added some comments.
Also:

• ios-spm-template already has the same files you created in the ios-spm-migrate-template, can't you use ios-spm-template files instead of a new ones?
• Do we need the --unsafe and --dry-run options? for --unsafe I assume people uses git or some other source control, so they could revert if they had some problem. And for --dry-run we are documenting the changes the command does so people can know.
• We have a separate ticket for the messaging/handling of non SPM plugins, so you can leave those changes out of the migration command.

• I can look into the best way to use the template files - it might be trivial to do that.
• I'm gonna ditch --unsafe but keep --dry-run, I think
• Non SPM plugins will just throw a warning for now - but I don't want to give people the idea it worked when it didn't.

So the npm tar package seems not to respect the file list you give it. I even enumerated every file, so I think the separate tarball works better - although we could at some point generate it directly from the template directory.

[jcesarmobile]

So the npm tar package seems not to respect the file list you give it. I even enumerated every file, so I think the separate tarball works better - although we could at some point generate it directly from the template directory.

I don't understand what you mean in the comment, but can't you extract it to a temp folder and copy the needed files to the user project?
I really don't want a separate template with duplicate files we have to maintain

[markemer]

So the npm tar package seems not to respect the file list you give it. I even enumerated every file, so I think the separate tarball works better - although we could at some point generate it directly from the template directory.

I don't understand what you mean in the comment, but can't you extract it to a temp folder and copy the needed files to the user project? I really don't want a separate template with duplicate files we have to maintain

Yeah, /tmp might be the way - tar should allow me to just untar the stuff I want - extract accepts a file list, but it seems to totally ignore it.

[jcesarmobile]

There are several comments that have not been addressed yet

[markemer]

There are several comments that have not been addressed yet

I just pushed the removal of Cap-SPM as a separate zip file, should be ready now.

[jcesarmobile]

The changes from https://github.com/ionic-team/capacitor/pull/7982/files need to be applied on the migration

[jcesarmobile]

The debug.xcconfig is not being added to the project (https://github.com/ionic-team/capacitor/blob/main/ios-spm-template/debug.xcconfig) and I think it should, or at least should be copied to the project folder and tell the users to manually add it to the Xcode project or explain how to create a new one, both in here and in the docs PR. But adding it or creating it and also adding the CapApp-SPM dependency seem like too much manual changes for a "migrate" command, so would be cool if the command could add it.

The Package.swift detection is not working properly, I get

Found 6 Plugins with Package.swift files:
@capacitor-community/[email protected]

and then

[warn] CapacitorCommunityTapJacking does not have a Package.swift

The plugin doesn't have a Package.swift, so the warning is correct, but shouldn't be listed as having it.
Anyway, I told you to remove that part from this PR since we have another ticket for that task and there are some other things that should be changed related to it, so better focus just on the migration task.

Also, can you remove the comments about you hating things?

[markemer]

The Package.swift detection is not working properly, I get

Found 6 Plugins with Package.swift files:
@capacitor-community/[email protected]

and then

[warn] CapacitorCommunityTapJacking does not have a Package.swift

Yeah, that's a new one on me - I'll take a look at why that's failing. The rest are no problem.

Also, can you remove the comments about you hating things?

Oh yeah, I didn't even mean to check that in. Moment of frustration with TS and all that.

Since I'm in here, I'll also change the name - it's gotten far enough away that I think you're right and I'm gonna call it spm-migration-assistant