Conversation
ShaneK
changed the title
6 tasks
brandyscarney
requested changes
Feb 24, 2025
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
brandyscarney
approved these changes
Feb 25, 2025
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Looks great! Huge thanks to Carniatto for doing most of the Angular standalone work, and to Shane for getting it across the finish line and adding support for Angular 19!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the conference app to Angular 19, it's branched off of PR #1817 and includes that work - updating all components to standalone. This PR should also fix the issue that was stopping that PR from building.
I made a new PR in this case because the goal has shifted from just the standalone component upgrade to also upgrading to Angular 19.
This PR also upgrades from Capacitor 4 to 6. Stopped before 7 because of a current issue with the way Framework uses the Capacitor API, but will upgrade to 7 after that's addressed.
Co-authored-by: carniatto mateus.carniatto@mylighthouse.com