-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angular-standalone): update eslint #1861
base: main
Are you sure you want to change the base?
Conversation
test are falling because the
or use |
I would use |
I've updated the whole refresher code to match the docs, but I find it weird that it was using the event detail before and now the event target |
Yeah it seems like we're inconsistent between the different frameworks: We should update these all to be the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this locally and verified that all Angular test apps pass linting without errors. Additionally, introducing a lint error in a test is correctly detected by the linter.
This should pass now with the latest Ionic release. |
eslint 9 changed the configuration files and
.eslintrc.json
no longer works.I first removed all the eslint related packages,
.eslintrc.json
file and eslint entries fromangular.json
.Then ran
ng add angular-eslint
, which installs eslint-angular and related packages and configure the project with default angular configuration, creating aeslint.config.js
and makes some automatic modifications toangular.json
.Then I replaced the
no-underscore-dangle
rule since it no longer caused issues, but added@typescript-eslint/no-explicit-any
as it complains about that now.Then removed
tseslint.configs.stylistic
config as it was causing lint errors about empty constructors.Finally added
Page
to valid component suffixes since it was causing a lint error that Pages weren't namedComponent
.I made all the steps as separate commits to see the process better, but should be squashed on merge
closes #1860