Update FSharp.Compiler.Service and FSharp.Core to the '9' versions #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
That bit looked fine to me. |
TheAngryByrd
force-pushed
the
bump_fcs
branch
from
76292cf to
726f6de
Compare
TheAngryByrd
previously requested changes
Nov 16, 2024
Member
TheAngryByrd
left a comment
TheAngryByrd
left a comment
There was a problem hiding this comment.
Thanks for this! Also pushed up changes that make it net8/9. Also gonna mark this as blocked until we release the proj-info package.
…ed runtime changes
baronfel
dismissed
TheAngryByrd’s stale review
The ProjInfo package is released and has been updated here
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #221
Note: I'm trying to learn a bit more about how this stuff works, so I'm not certain how the new null AST bits like
SynType.WithNullshould be handled