Perf: Move membersToIgnore/exprTypesToIgnore out of visitDeclaration() #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
approved these changes
Jul 14, 2025
TheAngryByrd
approved these changes
Jul 16, 2025
Member
|
Thanks! I'll merge it when I'm ready to release. |
TheAngryByrd
changed the title
This was referenced Aug 4, 2025
This was referenced Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a thought when playing with things - looks like creating these sets inside
visitDeclarationcreates a substantial number of lists and sets, and as the contents are constant it doesn't seem like it should need to create them more than once?Running a memory profile of the SDK cli tool against one of my projects got this before:
and this after: