Add EditorContext to OptionAnalyzer sample #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAngryByrd
commented
Sep 13, 2025
| let walker = | ||
| { new TypedTreeCollectorBase() with | ||
| override _.WalkCall _ m _ _ _ range = | ||
| m.DeclaringEntity |
Member
Author
There was a problem hiding this comment.
Would you believe the analyzer itself was violating it's own premise?
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds EditorContext support to the OptionAnalyzer by refactoring the analyzer logic into a shared handler function and creating separate analyzers for both CLI and Editor contexts.
- Extracted the main analyzer logic into a reusable
handlerfunction - Added a new
analyzerEditorContextanalyzer withEditorAnalyzerAttribute - Updated the existing CLI analyzer to use the shared handler
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
TheAngryByrd
force-pushed
the
246-option-analyzer-editor-context
branch
from
05e1c92 to
3a175f8
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
TheAngryByrd
changed the title
This was referenced Oct 20, 2025
This was referenced Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #246