Skip to content

Conversation

@Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Nov 9, 2025

There are no functional changes here, but it does pick up several transitive dependency updates which fixes some CVE vulnernability warnings in the build.

There is one little issue with this in that Fornax is building with FSharp.Core 8.0.100 and the newer FAKE wants 8.0.400, but hopefully it's ok for the build script to use a newer version and the actual Fornax tool to continue with the existing version.

There are no functional changes here, but it does pick up several transitive dependency updates which fixes some CVE vulternability warnings in the build.

There is one little issue with this in that Fornax is building with FSharp.Core 8.0.100 and the newer FAKE wants 8.0.400, but hopefully it's ok for the build script to use a newer version and the actual Fornax tool to continue with the existing version.
@Numpsy
Copy link
Contributor Author

Numpsy commented Nov 9, 2025

The CVE warnings in question being these:

image

@TheAngryByrd
Copy link
Member

We can always pin to a known good dependency. I haven't looked at the specific CVEs, is this something we should even worry about for a dev time dependency?

@TheAngryByrd TheAngryByrd merged commit 8a03276 into ionide:master Nov 9, 2025
3 checks passed
@Numpsy Numpsy deleted the fake_614 branch November 10, 2025 11:05
@Numpsy
Copy link
Contributor Author

Numpsy commented Nov 10, 2025

We can always pin to a known good dependency. I haven't looked at the specific CVEs, is this something we should even worry about for a dev time dependency?

I thought maybe the NuGet libs could be getting used for the script that publishes the NuGet packages, but looking at the FAKE code it might be calling the command line tool rather than using the libraries (The security tools of course can't see that, only that the dependency exists)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants