Skip to content

Start of fsdocs page #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nhirschey wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Start of fsdocs page #1302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcd5e64
Start of fsdocs page
nhirschey May 28, 2024
a0239f4
fix rollForward
nhirschey May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .config/dotnet-tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@
"telplin"
],
"rollForward": false
},
"fsdocs-tool": {
"version": "20.0.0",
"commands": [
"fsdocs"
],
"rollForward": false
}
}
}
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,7 @@ test/FsAutoComplete.Tests.Lsp/TestResults/
.tool-versions
BenchmarkDotNet.Artifacts/

*.sarif
*.sarif

tmp/*
.fsdocs/*
8 changes: 8 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,12 @@
<IsPackable>false</IsPackable>
</PropertyGroup>

<PropertyGroup>
<RepositoryUrl>https://github.com/ionide/FsAutoComplete</RepositoryUrl>
<FsDocsLicenseLink>https://github.com/ionide/FsAutoComplete/blob/main/LICENSE.md</FsDocsLicenseLink>
<FsDocsReleaseNotesLink>https://github.com/ionide/FsAutoComplete/blob/main/CHANGELOG.md</FsDocsReleaseNotesLink>
<PackageProjectUrl>https://ionide.io/Tools/fsac.html</PackageProjectUrl>
Comment on lines +22 to +25
Copy link
Contributor

@baronfel baronfel May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my fork I was actually a bit irritated at this - this data (at least the RepositoryUrl) should be available in the build already. I dug into it a bit and realized that the RepositoryUrl is set by the NuGet Pack targets, but it's only done a) for Pack and b) if the user has a few other sentinel properties set up (which usually are handled by the SDK/SourceLink by default).

So I guess I think that FSharp.Formatting should ideally be able to recognize this pattern and adhere to it, in the absence of that getting fixed/changed at the SDK level?

<FsDocsLogoSource>images/logo.png</FsDocsLogoSource>
</PropertyGroup>

</Project>
Binary file added docs/images/logo.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions docs/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Home page