Extract MSBuild evaluation to separate build server process with dedicated protocol project

FsAutoComplete.sln

@@ -27,6 +27,10 @@ Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "FsAutoComplete.DependencyMa
 EndProject
 Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "benchmarks", "benchmarks\benchmarks.fsproj", "{0CD029D8-B39E-4CBE-A190-C84A7A811180}"
 EndProject
+Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "FsAutoComplete.BuildServer", "src\FsAutoComplete.BuildServer\FsAutoComplete.BuildServer.fsproj", "{20A60741-D0BB-43AE-8912-21C4D3F3817E}"
+EndProject
+Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "FsAutoComplete.BuildServerProtocol", "src\FsAutoComplete.BuildServerProtocol\FsAutoComplete.BuildServerProtocol.fsproj", "{35E025B2-B255-4E95-A5C6-B8B52361808F}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -65,6 +69,14 @@ Global
 		{0CD029D8-B39E-4CBE-A190-C84A7A811180}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{0CD029D8-B39E-4CBE-A190-C84A7A811180}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{0CD029D8-B39E-4CBE-A190-C84A7A811180}.Release|Any CPU.Build.0 = Release|Any CPU
+		{20A60741-D0BB-43AE-8912-21C4D3F3817E}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{20A60741-D0BB-43AE-8912-21C4D3F3817E}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{20A60741-D0BB-43AE-8912-21C4D3F3817E}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{20A60741-D0BB-43AE-8912-21C4D3F3817E}.Release|Any CPU.Build.0 = Release|Any CPU
+		{35E025B2-B255-4E95-A5C6-B8B52361808F}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{35E025B2-B255-4E95-A5C6-B8B52361808F}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{35E025B2-B255-4E95-A5C6-B8B52361808F}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{35E025B2-B255-4E95-A5C6-B8B52361808F}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
@@ -74,6 +86,8 @@ Global
 		{38C1F619-3E1E-4784-9833-E8A2AA95CDAE} = {BA56455D-4AEA-45FC-A569-027A68A76BA6}
 		{14C55B44-2063-4891-98BE-8184CAB1BE87} = {443E0B8D-9AD0-436E-A331-E8CC12965F07}
 		{C58701B0-D8E3-4B68-A7DE-8524C95F86C0} = {443E0B8D-9AD0-436E-A331-E8CC12965F07}
+		{20A60741-D0BB-43AE-8912-21C4D3F3817E} = {BA56455D-4AEA-45FC-A569-027A68A76BA6}
+		{35E025B2-B255-4E95-A5C6-B8B52361808F} = {BA56455D-4AEA-45FC-A569-027A68A76BA6}
 	EndGlobalSection
 	GlobalSection(ExtensibilityGlobals) = postSolution
 		SolutionGuid = {1C4EE83B-632A-4929-8C96-38F14254229E}

global.json

@@ -1,6 +1,6 @@
 {
   "sdk": {
-    "version": "8.0.300",
+    "version": "8.0.119",
     "rollForward": "latestMajor",
     "allowPrerelease": true
   }

paket.dependencies

@@ -25,6 +25,7 @@ nuget Microsoft.CodeAnalysis
 nuget FSharp.Analyzers.SDK 0.32.1
 nuget ICSharpCode.Decompiler
 nuget Mono.Cecil >= 0.11.4
+nuget Newtonsoft.Json >= 13.0
 nuget FSharpLint.Core
 nuget Serilog >= 2.10.0
 nuget Serilog.Sinks.File >= 5.0.0

src/FsAutoComplete.BuildServer/FsAutoComplete.BuildServer.fsproj

@@ -0,0 +1,19 @@
+<Project Sdk="Microsoft.NET.Sdk">
+  <PropertyGroup>
+    <TargetFrameworks>net8.0</TargetFrameworks>
+    <TargetFrameworks Condition="'$(BuildNet9)' == 'true'">net8.0;net9.0</TargetFrameworks>
+    <OutputType>Exe</OutputType>
+    <IsPackable>false</IsPackable>
+    <AssemblyName>fsautocomplete-buildserver</AssemblyName>
+  </PropertyGroup>
+  <ItemGroup>
+    <ProjectReference Include="..\FsAutoComplete.Logging\FsAutoComplete.Logging.fsproj" />
+    <ProjectReference Include="../FsAutoComplete.BuildServerProtocol/FsAutoComplete.BuildServerProtocol.fsproj" />
+  </ItemGroup>
+  <ItemGroup>
+    <Compile Include="WorkspaceOperations.fs" />
+    <Compile Include="JsonRpcServer.fs" />
+    <Compile Include="Program.fs" />
+  </ItemGroup>
+  <Import Project="..\..\.paket\Paket.Restore.targets" />
+</Project>

src/FsAutoComplete.BuildServer/JsonRpcServer.fs

@@ -0,0 +1,204 @@
+namespace FsAutoComplete.BuildServer
+
+open System
+open System.IO
+open System.Text
+open System.Threading.Tasks
+open Newtonsoft.Json
+open Newtonsoft.Json.Linq
+open FsAutoComplete.Logging
+open FsAutoComplete.BuildServerProtocol.JsonRpc
+open FsAutoComplete.BuildServerProtocol.BuildServerProtocol
+open WorkspaceOperations
+
+/// JSON RPC server for Build Server Protocol communication
+module JsonRpcServer =
+
+  let private logger = LogProvider.getLoggerByName "JsonRpcServer"
+
+  type RequestHandler = JsonRpcRequest -> Task<JsonRpcResponse>
+  type NotificationHandler = JsonRpcNotification -> Task<unit>
+
+  let private jsonSettings = 
+    JsonSerializerSettings(
+      NullValueHandling = NullValueHandling.Ignore,
+      DefaultValueHandling = DefaultValueHandling.Ignore)
+
+  let private serialize obj = 
+    JsonConvert.SerializeObject(obj, jsonSettings)
+
+  let private deserialize<'T> (json: string) = 
+    JsonConvert.DeserializeObject<'T>(json, jsonSettings)
+
+  let private tryDeserialize<'T> (token: JToken) = 
+    try
+      Some (token.ToObject<'T>())
+    with
+    | _ -> None
+
+  /// Create a successful response
+  let private createSuccessResponse (id: JToken option) (result: obj) =
+    { Id = id
+      Result = Some (JToken.FromObject(result))
+      Error = None }
+
+  /// Create an error response
+  let private createErrorResponse (id: JToken option) (code: int) (message: string) =
+    { Id = id
+      Result = None
+      Error = Some { Code = code; Message = message; Data = None } }
+
+  /// Handle BSP requests
+  let private handleBspRequest (request: JsonRpcRequest) : Task<JsonRpcResponse> =
+    task {
+      try
+        logger.info (Log.setMessage "Handling BSP request: {method}" >> Log.addContext "method" request.Method)
+
+        match request.Method with
+        | "build/initialize" ->
+          let! result = initializeWorkspace()
+          match result with
+          | Result.Ok () ->
+            let capabilities = { 
+              CompileProvider = Some true
+              TestProvider = None
+              RunProvider = None
+              DebugProvider = None
+              InverseSourcesProvider = None
+              DependencySourcesProvider = None
+              DependencyModulesProvider = None
+              ResourcesProvider = None
+              OutputPathsProvider = None
+              BuildTargetChangedProvider = None
+              JvmRunEnvironmentProvider = None
+              JvmTestEnvironmentProvider = None
+              CanReload = Some true 
+            }
+            return createSuccessResponse (Some request.Id) capabilities
+          | Result.Error msg ->
+            return createErrorResponse (Some request.Id) ErrorCodes.InternalError msg
+
+        | "build/shutdown" ->
+          let! result = shutdown()
+          match result with
+          | Result.Ok () ->
+            return createSuccessResponse (Some request.Id) ()
+          | Result.Error msg ->
+            return createErrorResponse (Some request.Id) ErrorCodes.InternalError msg
+
+        | "workspace/buildTargets" ->
+          // Return empty build targets for now
+          let result = { Targets = [||] }
+          return createSuccessResponse (Some request.Id) result
+
+        | "fsharp/workspacePeek" ->
+          match request.Params with
+          | Some parameters ->
+            match tryDeserialize<WorkspacePeekRequest> parameters with
+            | Some peekRequest ->
+              let! result = peekWorkspace peekRequest
+              match result with
+              | Result.Ok response ->
+                return createSuccessResponse (Some request.Id) response
+              | Result.Error msg ->
+                return createErrorResponse (Some request.Id) ErrorCodes.InternalError msg
+            | None ->
+              return createErrorResponse (Some request.Id) ErrorCodes.InvalidParams "Invalid workspace peek parameters"
+          | None ->
+            return createErrorResponse (Some request.Id) ErrorCodes.InvalidParams "Missing workspace peek parameters"
+
+        | "fsharp/workspaceLoad" ->
+          match request.Params with
+          | Some parameters ->
+            match tryDeserialize<WorkspaceLoadRequest> parameters with
+            | Some loadRequest ->
+              let! result = loadWorkspace loadRequest  
+              match result with
+              | Result.Ok response ->
+                return createSuccessResponse (Some request.Id) response
+              | Result.Error msg ->
+                return createErrorResponse (Some request.Id) ErrorCodes.InternalError msg
+            | None ->
+              return createErrorResponse (Some request.Id) ErrorCodes.InvalidParams "Invalid workspace load parameters"
+          | None ->
+            return createErrorResponse (Some request.Id) ErrorCodes.InvalidParams "Missing workspace load parameters"
+
+        | _ ->
+          logger.warn (Log.setMessage "Unknown method: {method}" >> Log.addContext "method" request.Method)
+          return createErrorResponse (Some request.Id) ErrorCodes.MethodNotFound $"Method not found: {request.Method}"
+      with
+      | ex ->
+        logger.error (Log.setMessage "Error handling request: {error}" >> Log.addContext "error" ex.Message)
+        return createErrorResponse (Some request.Id) ErrorCodes.InternalError ex.Message
+    }
+
+  /// Handle JSON RPC notifications
+  let private handleNotification (notification: JsonRpcNotification) : Task<unit> =
+    task {
+      try
+        logger.info (Log.setMessage "Handling notification: {method}" >> Log.addContext "method" notification.Method)
+
+        match notification.Method with
+        | "build/exit" ->
+          logger.info (Log.setMessage "Received exit notification")
+          Environment.Exit(0)
+        | _ ->
+          logger.warn (Log.setMessage "Unknown notification method: {method}" >> Log.addContext "method" notification.Method)
+      with
+      | ex ->
+        logger.error (Log.setMessage "Error handling notification: {error}" >> Log.addContext "error" ex.Message)
+    }
+
+  /// Process a single JSON RPC message
+  let processMessage (messageText: string) : Task<string option> =
+    task {
+      try
+        let message = JObject.Parse(messageText)
+
+        if message.ContainsKey("id") then
+          // This is a request
+          let request = message.ToObject<JsonRpcRequest>()
+          let! response = handleBspRequest request
+          return Some (serialize response)
+        else
+          // This is a notification
+          let notification = message.ToObject<JsonRpcNotification>()
+          do! handleNotification notification
+          return None
+      with
+      | ex ->
+        logger.error (Log.setMessage "Error processing message: {error}" >> Log.addContext "error" ex.Message)
+        let errorResponse = createErrorResponse None ErrorCodes.ParseError "Parse error"
+        return Some (serialize errorResponse)
+    }
+
+  /// Main server loop for stdin/stdout communication
+  let runServer () =
+    task {
+      logger.info (Log.setMessage "Starting JSON RPC server...")
+
+      use reader = new StreamReader(Console.OpenStandardInput())
+      use writer = new StreamWriter(Console.OpenStandardOutput())
+      writer.AutoFlush <- true
+
+      let mutable keepRunning = true
+
+      while keepRunning do
+        try
+          let! line = reader.ReadLineAsync()
+          if not (isNull line) then
+            let! response = processMessage line
+            match response with
+            | Some responseText ->
+              do! writer.WriteLineAsync(responseText)
+            | None ->
+              () // No response needed for notifications
+          else
+            keepRunning <- false
+        with
+        | ex ->
+          logger.error (Log.setMessage "Server loop error: {error}" >> Log.addContext "error" ex.Message)
+          keepRunning <- false
+
+      logger.info (Log.setMessage "JSON RPC server stopped")
+    }

src/FsAutoComplete.BuildServer/Program.fs

@@ -0,0 +1,21 @@
+module FsAutoComplete.BuildServer.Program
+
+open System
+open System.IO
+open FsAutoComplete.Logging
+open JsonRpcServer
+
+[<EntryPoint>]
+let main _args =
+  // Set up basic logging
+  printfn "FsAutoComplete Build Server starting"
+
+  try
+    // Run the JSON RPC server
+    let serverTask = runServer()
+    serverTask.Wait()
+    0
+  with
+  | ex ->
+    printfn "Build server error: %s" ex.Message
+    1

src/FsAutoComplete.BuildServer/WorkspaceOperations.fs

@@ -0,0 +1,35 @@
+namespace FsAutoComplete.BuildServer
+
+open System
+open System.IO
+open System.Threading.Tasks
+open FsAutoComplete.Logging
+open FsAutoComplete.BuildServerProtocol.JsonRpc
+open FsAutoComplete.BuildServerProtocol.BuildServerProtocol
+
+/// Simple workspace operations for Build Server Protocol
+module WorkspaceOperations =
+
+  let private logger = LogProvider.getLoggerByName "WorkspaceOperations"
+
+  /// Initialize workspace - for now just log and return success
+  let initializeWorkspace () =
+    logger.info (Log.setMessage "Initializing workspace...")
+    Task.FromResult(Result.Ok ())
+
+  /// Peek workspace - simplified for now
+  let peekWorkspace (request: WorkspacePeekRequest) =
+    logger.info (Log.setMessage "Peeking workspace at {directory}" >> Log.addContext "directory" request.Directory)
+    let response = { Found = [||] }
+    Task.FromResult(Result.Ok response)
+
+  /// Load workspace - simplified for now 
+  let loadWorkspace (request: WorkspaceLoadRequest) =
+    logger.info (Log.setMessage "Loading workspace with {documentCount} documents" >> Log.addContext "documentCount" request.TextDocuments.Length)
+    let response = { WorkspaceRoot = Environment.CurrentDirectory; Projects = [||] }
+    Task.FromResult(Result.Ok response)
+
+  /// Shutdown workspace
+  let shutdown () =
+    logger.info (Log.setMessage "Shutting down workspace...")
+    Task.FromResult(Result.Ok ())

src/FsAutoComplete.BuildServer/paket.references

@@ -0,0 +1,2 @@
+FSharp.Core
+Newtonsoft.Json